Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF87 removing -moz media features #2567

Merged
merged 3 commits into from
Mar 16, 2021
Merged

FF87 removing -moz media features #2567

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27511f6
removing -moz media features
rachelandrew Feb 22, 2021
3cc1509
Merge branch 'main' into theme-related-mqs
chrisdavidmills Mar 15, 2021
6395e4b
copy edit
chrisdavidmills Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions files/en-us/mozilla/firefox/releases/87/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,26 @@ <h3 id="CSS">CSS</h3>

<h4 id="Removals_3">Removals</h4>

<ul>
<li>The following theme-related media features have been disabled for use in web pages ({{bug(787521)}}):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe add in "Firefox-specific" to this sentence, just so we are completely clear that they are proprietary. I know it's pretty obvious, but...

<ul>
<li><code>-moz-mac-graphite-theme</code></li>
<li><code>-moz-mac-lion-theme</code></li>
<li><code>-moz-maemo-classic</code></li>
<li><code>-moz-windows-classic</code></li>
<li><code>-moz-windows-compositor</code></li>
<li><code>-moz-windows-default-theme</code></li>
<li><code>-moz-windows-theme</code></li>
<li><code>-moz-scrollbar-end-backward</code></li>
<li><code>-moz-scrollbar-end-forward</code></li>
<li><code>-moz-scrollbar-start-backward</code></li>
<li><code>-moz-scrollbar-start-forward</code></li>
<li><code>-moz-scrollbar-thumb-proportional</code></li>
<li><code>-moz-menubar-drag</code></li>
</ul>
</li>
</ul>

<h3 id="JavaScript">JavaScript</h3>

<h4 id="Removals_4">Removals</h4>
Expand Down
12 changes: 0 additions & 12 deletions files/en-us/web/css/mozilla_extensions/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,22 +643,10 @@ <h2 id="Media_features">Media features</h2>

<div class="index">
<ul>
<li>{{CSSxRef("@media/-moz-mac-graphite-theme", "-moz-mac-graphite-theme")}}{{gecko_minversion_inline("1.9.2")}}</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether the removed ones had specific pages written about them? If there are any, it'd be good to have those removed too, and the URLs redirected to somewhere like the @media landing page...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, https://developer.mozilla.org/en-US/docs/Archive/Web/CSS/@media/-moz-scrollbar-end-backward

It is in the archive, but perhaps you could remove it and redirect, just to tidy up a bit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's not worry about this one.

<li>{{CSSxRef("@media/-moz-maemo-classic", "-moz-maemo-classic")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-device-pixel-ratio", "-moz-device-pixel-ratio")}}{{gecko_minversion_inline("2.0")}}</li>
<li>{{CSSxRef("@media/-moz-os-version", "-moz-os-version")}}</li>
<li>{{CSSxRef("@media/-moz-scrollbar-end-backward", "-moz-scrollbar-end-backward")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-scrollbar-end-forward", "-moz-scrollbar-end-forward")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-scrollbar-start-backward", "-moz-scrollbar-start-backward")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-scrollbar-start-forward", "-moz-scrollbar-start-forward")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-scrollbar-thumb-proportional", "-moz-scrollbar-thumb-proportional")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-touch-enabled", "-moz-touch-enabled")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-windows-accent-color-in-titlebar", "-moz-windows-accent-color-in-titlebar")}}</li>
<li>{{CSSxRef("@media/-moz-windows-classic", "-moz-windows-classic")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-windows-compositor", "-moz-windows-compositor")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-windows-default-theme", "-moz-windows-default-theme")}}{{gecko_minversion_inline("1.9.2")}}</li>
<li>{{CSSxRef("@media/-moz-windows-glass", "-moz-windows-glass")}}</li>
<li>{{CSSxRef("@media/-moz-windows-theme", "-moz-windows-theme")}}{{gecko_minversion_inline("2.0")}}</li>
</ul>
</div>

Expand Down