Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: tweaks to color-mix() and hue #25685

Merged
merged 23 commits into from
Mar 27, 2023
Merged

Minor: tweaks to color-mix() and hue #25685

merged 23 commits into from
Mar 27, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 27, 2023

Edits I was unable to get into the origin PR
Hoping to make content simpler to understand.

bsmth and others added 23 commits March 15, 2023 21:12
@bsmth
docs(CSS): add examples of hue interpolation methods, add hue page
ca139af
@bsmth
docs(CSS): add examples of hue interpolation methods, add hue page
b948c02
@bsmth
docs(CSS): add examples of hue interpolation methods, add hue page
62f92f4
@bsmth
docs(CSS): consistent use of lt gt brackets inside cssref macros
62bb4c4
@bsmth
Merge branch 'main' into 358_hue-interpolation-method
5a9bca5
@bsmth @dawei-wang
Update files/en-us/web/css/color_value/index.md
2fc50b6 
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
@bsmth
docs(CSS): fix some flaws for links to CSS ref pages
05a5e7b
@bsmth @argyleink
Update files/en-us/web/css/hue/index.md
2053810 
Co-authored-by: Adam Argyle <argyle@google.com>
@bsmth
docs(CSS): use front-matter suggestion from Estelle on hue page, add …
a38961b 
…oklch and oklab
@estelle
Apply suggestions from code review
c467165
@estelle
space
746fe2a
@estelle
white space
37ba6ef
@estelle @teoli2003
Apply suggestions from code review
57696e9 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle
creating a repo
df9e75f
@estelle
Merge pull request #322 from bsmth/358_hue-interpolation-method
833cbc8 
358 hue interpolation method
@estelle
tweaks to example, hsl -> hwb typo, explain color wheel
c188432
@estelle
peru to plum, tweaks to example, intro paragraph, explain default value
2dd8241
@estelle
foobar
d6fabf7
@estelle
Update files/en-us/web/http/browser_detection_using_the_user_agent/in…
f044369 
…dex.md
@estelle
Update files/en-us/web/http/browser_detection_using_the_user_agent/in…
f418eee 
…dex.md
@estelle
Update files/en-us/web/css/css_colors/index.md
1c534d2
@estelle
Link case
c71f170
@estelle
link
fc18338
@estelle estelle requested a review from a team as a code owner March 27, 2023 18:34
@estelle estelle requested review from dipikabh and removed request for a team March 27, 2023 18:34
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 27, 2023
@github-actions
Copy link
Contributor

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/hue
Title: <hue>
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.types.hue
External URLs (1)

URL: /en-US/docs/Web/CSS/hue
Title: <hue>

teoli2003
teoli2003 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 6ffb078 into mdn:main Mar 27, 2023
@estelle estelle mentioned this pull request Apr 22, 2023
Open
@estelle estelle deleted the newcolor branch July 14, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @teoli2003 @bsmth