-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New page: overflow values #26395
New page: overflow values #26395
Conversation
Preview URLs Flaws (1)URL:
(comment last updated: 2023-04-27 20:07:15) |
Thanks, @estelle. I'll start reviewing this tomorrow. |
Hi @estelle, the Overflow specification does not define Could we instead use the overflow property page as the deep dive location for the values and link other overflow-* property values to the overflow property page? As an example of a property-* page, min-block-size values and min-inline-size values do this and also the inset-* properties. As an aside - I don't think there is any other "_value" data type page (overflow_value used in the slug for the new page) in the "Types" sidebar grouping. |
It doesn't defined it as a data type. Similar to
as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting around to the idea of having a page for enumerated value type! Suggested some edits and rephrasing
slug: Web/CSS/overflow_value | ||
page-type: css-type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slug: Web/CSS/overflow_value | |
page-type: css-type | |
slug: Web/CSS/overflow_values | |
page-type: css-value-type |
or maybe page-type: css-enumerated-value-type
?
Just a suggestion for a different page type. We might want to try a different page type for these types of pages. You'd have better ideas here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now, we are adding this as a regular value type. We can change if we think it doesn't work live.
For the slug, other CSS data types use "value" not "values.
title: <overflow> | ||
slug: Web/CSS/overflow_value | ||
page-type: css-type | ||
browser-compat: css.types.overflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bcd file location will also need to change. A new folder for values
?
There's folders for at-rules, selectors, properties, and types at present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're pretending this is a regular data type for now: it's just enumerated rather than functional or numeric like the other ones
|
||
### Results | ||
|
||
{{EmbedLiveSample("Examples", "500", "600")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to increase the length of the iframe here to contain all the examples
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
The
<overflow>
values are used in multiple properties. Instead of defining the values in each location, we can provide a deep dive in one location and refer to this page when using the value type.