Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS overflow module #26425

Merged
merged 7 commits into from
Apr 28, 2023
Merged

CSS overflow module #26425

merged 7 commits into from
Apr 28, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 26, 2023

@estelle estelle requested a review from a team as a code owner April 26, 2023 00:41
@estelle estelle requested review from dipikabh and removed request for a team April 26, 2023 00:41
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 26, 2023
@estelle estelle mentioned this pull request Apr 26, 2023
Open
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

Preview URLs

Flaws (6)

URL: /en-US/docs/Web/CSS/CSS_Overflow
Title: CSS Overflow
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/block-ellipsis does not exist
    • /en-US/docs/Web/CSS/continue does not exist
    • /en-US/docs/Web/CSS/line-clamp does not exist
    • /en-US/docs/Web/CSS/max-lines does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/overflow_value
    • Can't resolve /en-US/docs/Web/CSS/CSS_scrollbars
External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_Overflow
Title: CSS Overflow

(comment last updated: 2023-04-27 04:56:36)

yarusome
yarusome reviewed Apr 26, 2023
View reviewed changes
files/en-us/web/css/css_overflow/index.md Outdated
Comment on lines 42 to 44
### Non-standard properties

- {{CSSxRef("-webkit-line-clamp")}} {{non-standard_inline}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is standardized in Level 4.

files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh self-assigned this Apr 26, 2023
dipikabh
dipikabh requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle, the example is really a great addition. Thank you!! 🙌

files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md
- {{CSSxRef("-webkit-line-clamp")}} {{non-standard_inline}}

### Data types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? 🙂

Suggested change
### Data types
### Enumerated values

Copy link
Member Author

@estelle estelle Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to keep it the same title as other landing pages (but feel free to commit if you disagree with me)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revisit this title if and when we do have the "Enumerated value types" category

files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Show resolved Hide resolved
files/en-us/web/css/css_overflow/index.md Outdated Show resolved Hide resolved
@estelle @dipikabh
Apply suggestions from code review
58f1c5f 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh April 27, 2023 04:54
dipikabh
dipikabh approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 👍

@dipikabh dipikabh merged commit 2e03de7 into mdn:main Apr 28, 2023
@dipikabh dipikabh mentioned this pull request May 24, 2023
Merged
@estelle estelle deleted the overflowmodule branch August 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 left review comments

@yarusome yarusome yarusome left review comments

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estelle @teoli2003 @dipikabh @yarusome