Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page-type for Web/Manifest #27621

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

teoli2003
Copy link
Contributor

Description

This adds the following page-type for web/manifest

web-manifest-member

Motivation

Members have a specific page structure

Additional details

Related issues and pull requests

This is part of openwebdocs/project#91

@teoli2003 teoli2003 requested a review from wbamberg June 28, 2023 13:09
@teoli2003 teoli2003 requested review from a team as code owners June 28, 2023 13:09
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jun 28, 2023
@github-actions
Copy link
Contributor

Preview URLs (23 pages)
Flaws (7)

Note! 19 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Manifest/short_name
Title: short_name
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Manifest/dir
    • Can't resolve /en-US/docs/Web/Manifest/lang

URL: /en-US/docs/Web/Manifest/name
Title: name
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Manifest/dir
    • Can't resolve /en-US/docs/Web/Manifest/lang

URL: /en-US/docs/Web/Manifest/share_target
Title: share_target
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Progressive_web_apps/Installable_PWAs

URL: /en-US/docs/Web/Manifest/description
Title: description
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Manifest/dir
    • Can't resolve /en-US/docs/Web/Manifest/lang

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @teoli2003 !

@wbamberg wbamberg merged commit 0c015b8 into mdn:main Jun 28, 2023
@wbamberg
Copy link
Collaborator

Actually, since this one adds a new page type, we need to update https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key as well.

@teoli2003
Copy link
Contributor Author

I'll do a follow-up for updating the metadocs

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants