Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page-types for WebDriver #27622

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Add page-types for WebDriver #27622

merged 3 commits into from
Jun 29, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Jun 28, 2023 •
edited
Loading

As part of openwebdocs/project#91, we want to add page-types to the WebDriver.

I propose to add 3 different page types:

Page type meaning
webdriver-command A webdriver command
webdriver-capability A webdriver capability
webdriver-error A webdriver error

This area of MDN is still a bit crude, so this list may be extended once more pages are written, but this cover all of them for now.

@teoli2003 teoli2003 requested a review from wbamberg June 28, 2023 13:37
@teoli2003 teoli2003 requested review from a team as code owners June 28, 2023 13:37
@github-actions github-actions bot added the Content:WebDriver WebDriver docs label Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

Preview URLs (30 pages)
Flaws (169)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key
Title: The page-type front matter key
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Animations
    • Can't resolve /en-US/docs/Web/API/Response/error
    • Can't resolve /en-US/docs/Web/API/Notification/permission

URL: /en-US/docs/Web/WebDriver
Title: WebDriver
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Types
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow

URL: /en-US/docs/Web/WebDriver/Capabilities
Title: Capabilities
Flaw count: 14

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/setWindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/browserName
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/browserVersion
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/platformName
    • and 9 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Capabilities/firefoxOptions
Title: firefoxOptions
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

URL: /en-US/docs/Web/WebDriver/Capabilities/acceptInsecureCerts
Title: acceptInsecureCerts
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

URL: /en-US/docs/Web/WebDriver/Capabilities/webSocketUrl
Title: webSocketUrl
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

URL: /en-US/docs/Web/WebDriver/Timeouts
Title: Timeouts
Flaw count: 8

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript
    • and 3 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors
Title: WebDriver errors
Flaw count: 37

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Response
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Clients
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ElementClickIntercepted
    • and 32 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors/InvalidCookieDomain
Title: Invalid cookie domain
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/AddCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/AddCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteAllCookies
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetAllCookies
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors/InvalidSelector
Title: Invalid selector
Flaw count: 11

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement#css-selector
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement#link-text-selector
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement#partial-link-text-selector
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement#tag-name-selector
    • and 6 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors/StaleElementReference
Title: Stale element reference
Flaw count: 9

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • and 4 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors/JavaScriptError
Title: JavaScript error
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript

URL: /en-US/docs/Web/WebDriver/Errors/ScriptTimeout
Title: Script timeout
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript

URL: /en-US/docs/Web/WebDriver/Errors/InvalidSessionID
Title: Invalid session ID
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteSession
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteSession

URL: /en-US/docs/Web/WebDriver/Errors/InsecureCertificate
Title: Insecure certificate
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowRect
Title: Get Window Rect
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Clients
    • Can't resolve /en-US/docs/Web/WebDriver/WindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/SetWindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • and 2 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/CloseWindow
Title: Close Window
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetWindowHandle

URL: /en-US/docs/Web/WebDriver/Commands/GetElementTagName
Title: Get Element Tag Name
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetTimeouts
Title: Get Timeouts
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ScriptTimeoutError

URL: /en-US/docs/Web/WebDriver/Commands/New_Window
Title: New Window
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnsupportedOperation

URL: /en-US/docs/Web/WebDriver/Commands/SetTimeouts
Title: Set Timeouts
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ScriptTimeoutError

URL: /en-US/docs/Web/WebDriver/Commands/SetWindowRect
Title: Set Window Rect
Flaw count: 11

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnsupportedOperation
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/setWindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/WindowRect
    • and 6 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowHandles
Title: Get Window Handles
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetWindowHandle

URL: /en-US/docs/Web/WebDriver/Commands/GetElementAttribute
Title: Get Element Attribute
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • and 2 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetElementProperty
Title: Get Element Property
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/Element/getProperty does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

(comment last updated: 2023-06-29 05:16:27)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 28, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

wbamberg
wbamberg reviewed Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add 3 different page types:
Page type meaning
webdriver-command A webdriver command
webdriver-capability A webdriver capability
webdriver-type A webdriver error

webdriver-error I think, not webdriver-type? But the PR is right.

This looks good but should also update https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key .

@teoli2003
Copy link
Contributor Author

I propose to add 3 different page types:
Page type meaning
webdriver-command A webdriver command
webdriver-capability A webdriver capability
webdriver-type A webdriver error

webdriver-error I think, not webdriver-type? But the PR is right.

I fixed the description

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 29, 2023
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jun 29, 2023
@teoli2003
Copy link
Contributor Author

Fixed.

@teoli2003 teoli2003 requested a review from wbamberg June 29, 2023 05:14
wbamberg
wbamberg approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @teoli2003 !

@wbamberg wbamberg merged commit ac24a64 into mdn:main Jun 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebDriver WebDriver docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @wbamberg