Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page-types to Learn/Getting_started, HTML & CSS #27644

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add page-types to Learn/Getting_started, HTML & CSS #27644

merged 2 commits into from
Jun 30, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Jun 29, 2023 •
edited
Loading

This is part of openwebdocs/project#91 and is the first piece of #27620

  • Adds page-type to the LA topics

  • Adds page-type to all Getting Started pages in LA

  • Adds page-type to all HTML pages in LA (including FAQ)

  • Adds page-type to all CSS pages in LA (including FAQ)

  • Update the front-matter config files so that linting will work.

@teoli2003 teoli2003 requested a review from wbamberg June 29, 2023 09:17
@teoli2003 teoli2003 requested review from a team as code owners June 29, 2023 09:17
@teoli2003 teoli2003 requested review from Elchi3 and chrisdavidmills and removed request for a team June 29, 2023 09:17
@github-actions github-actions bot added the Content:Learn Learning area docs label Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023 •
edited
Loading

Preview URLs (125 pages)
Flaws (45)

Note! 97 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Getting_started_with_the_web/What_will_your_website_look_like
Title: What will your website look like?
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Colors/Color_picker_tool

URL: /en-US/docs/Learn/CSS/First_steps/What_is_CSS
Title: What is CSS?
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Animations
    • Can't resolve /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders

URL: /en-US/docs/Learn/CSS/First_steps/How_CSS_is_structured
Title: How CSS is structured
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Learn/CSS/Howto
Title: Use CSS to solve common problems
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Learn/CSS/Howto/create_fancy_boxes
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox
    • Can't resolve /en-US/docs/Web/CSS/CSS_Columns/Using_multi-column_layouts
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout

URL: /en-US/docs/Learn/CSS/Howto/Create_fancy_boxes
Title: Create fancy boxes
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders
    • Can't resolve /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
    • Can't resolve /en-US/docs/Web/CSS/CSS_Images/Using_CSS_gradients

URL: /en-US/docs/Learn/CSS/Howto/Transition_button
Title: How to fade a button on hover
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Transitions/Using_CSS_transitions

URL: /en-US/docs/Learn/CSS/Howto/CSS_FAQ
Title: CSS FAQ
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Gecko_Almost_Standards_Mode
    • Can't resolve /en-US/docs/Web/CSS/Microsoft_Extensions

URL: /en-US/docs/Learn/CSS/Howto/Add_a_shadow
Title: How to add a shadow to an element
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Box-shadow_generator

URL: /en-US/docs/Learn/CSS/Howto/Make_box_transparent
Title: How to make a box semi-transparent
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Colors/Applying_color

URL: /en-US/docs/Learn/CSS/CSS_layout
Title: CSS layout
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Typical_Use_Cases_of_Flexbox

URL: /en-US/docs/Learn/CSS/CSS_layout/Introduction
Title: Introduction to CSS layout
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Columns
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout

URL: /en-US/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers
Title: Supporting older browsers
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_and_Progressive_Enhancement
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout/Backwards_Compatibility_of_Flexbox
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/CSS_Grid_and_Progressive_Enhancement

URL: /en-US/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Responsive design
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Learn/CSS/CSS_layout/Flexbox
Title: Flexbox
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout

URL: /en-US/docs/Learn/CSS/CSS_layout/Normal_Flow
Title: Normal Flow
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing

URL: /en-US/docs/Learn/CSS/CSS_layout/Grids
Title: Grids
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout#guides

URL: /en-US/docs/Learn/CSS/CSS_layout/Multiple-column_Layout
Title: Multiple-column layout
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Fragmentation
    • Can't resolve /en-US/docs/Web/CSS/CSS_Fragmentation
    • Can't resolve /en-US/docs/Web/CSS/CSS_Columns/Using_multi-column_layouts

URL: /en-US/docs/Learn/CSS/CSS_layout/Media_queries
Title: Beginner's guide to media queries
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries/Using_media_queries#syntax

URL: /en-US/docs/Learn/CSS/Styling_text/Web_fonts
Title: Web fonts
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Fonts/Variable_Fonts_Guide

URL: /en-US/docs/Learn/CSS/Building_blocks/Organizing
Title: Organizing your CSS
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout

URL: /en-US/docs/Learn/CSS/Building_blocks/Cascade_and_inheritance
Title: Cascade, specificity, and inheritance
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Learn/CSS/Building_blocks//selectors/combinators

URL: /en-US/docs/Learn/CSS/Building_blocks/Handling_different_text_directions
Title: Handling different text directions
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Logical_Properties

URL: /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
Title: Advanced styling effects
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Shapes
    • Can't resolve /en-US/docs/Web/CSS/CSS_Shapes/Overview_of_CSS_Shapes

URL: /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
Title: Cascade layers
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Conditional_Rules/Using_Feature_Queries
    • Can't resolve /en-US/docs/Web/CSS/CSS_Conditional_Rules/Using_Feature_Queries

URL: /en-US/docs/Learn/CSS/Building_blocks/The_box_model
Title: The box model
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flow_Layout/Block_and_Inline_Layout_in_Normal_Flow
    • Can't resolve /en-US/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing

URL: /en-US/docs/Learn/HTML/Howto/Author_fast-loading_HTML_pages
Title: Tips for authoring fast-loading HTML pages
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Document/load_event does not exist

URL: /en-US/docs/Learn/HTML/Howto/Use_data_attributes
Title: Using data attributes
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Getting_started
Title: Getting started with HTML
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Colors/Applying_color

(comment last updated: 2023-06-30 06:22:01)

@teoli2003
Copy link
Contributor Author

teoli2003 commented Jun 29, 2023 •
edited
Loading

I have a second and last PR for the Learning Area ready, but I can't create the PR as it needs this one to land first (as it contains a chance for the front-matter linter).

wbamberg
wbamberg reviewed Jun 29, 2023
View reviewed changes
files/en-us/learn/css/building_blocks/advanced_styling_effects/index.md
@@ -1,6 +1,7 @@
---
title: Advanced styling effects
slug: Learn/CSS/Building_blocks/Advanced_styling_effects
page-type: guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this is not a module chapter. But that seems to be a Learn area problem not a page type problem.

wbamberg
wbamberg reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teoli2003 ! I see one that looks wrong.

But there are a few you've marked guide, which looks like it points to errors in our IA for Learn. I think there should be no guide pages in Learn: for one thing, Learn has a quite opinionated organization, which does not have space for random guide pages; for another, they are not discoverable in the nav. Fix as a follow-up?

files/en-us/learn/css/css_layout/multicol_skills/index.md Outdated Show resolved Hide resolved
files/en-us/learn/css/css_layout/practical_positioning_examples/index.md
@@ -1,6 +1,7 @@
---
title: Practical positioning examples
slug: Learn/CSS/CSS_layout/Practical_positioning_examples
page-type: guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one. Why isn't this integrated into the module?

@teoli2003
Copy link
Contributor Author

teoli2003 commented Jun 30, 2023 •
edited
Loading

Yes I found quite a few pages not in the usual IA. I labelled them with guide for the moment. I propose to do a follow-up PR with these (they are quite easy to find as they will. have this page-type). I will fix the other one. (This likely needs an update of the sidebar, and that can take some time to land)

@teoli2003 @wbamberg
Update files/en-us/learn/css/css_layout/multicol_skills/index.md
eb24105 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 teoli2003 requested a review from wbamberg June 30, 2023 06:16
wbamberg
wbamberg approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@wbamberg wbamberg merged commit 751d586 into mdn:main Jun 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-http

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:Learn Learning area docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @wbamberg