Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: CSS namespace module and add CSS & HTML to glossary #27664

Merged
merged 9 commits into from
Jul 7, 2023
Merged

Rewrite: CSS namespace module and add CSS & HTML to glossary #27664

merged 9 commits into from
Jul 7, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 29, 2023

Part of the CSS modules project

  • add explanation, related concepts, guides, and see also to CSS module page
  • add html/xml/css/svg to namespace glossary

@estelle estelle requested review from a team as code owners June 29, 2023 21:34
@estelle estelle requested review from chrisdavidmills and removed request for a team June 29, 2023 21:34
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries labels Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023 •
edited
Loading

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_namespaces
Title: CSS namespaces
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_selectors

(comment last updated: 2023-07-07 02:14:20)

@estelle estelle mentioned this pull request Jun 29, 2023
Closed
6 tasks
@estelle estelle requested a review from dipikabh July 6, 2023 21:16
@dipikabh
Copy link
Contributor

dipikabh commented Jul 7, 2023

Sorry, this missed my radar. Taking a look at this now.

dipikabh
dipikabh requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates, @estelle!

files/en-us/glossary/namespace/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/namespace/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
@estelle @dipikabh
Apply suggestions from code review
f59bea1 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh July 7, 2023 02:04
dipikabh
dipikabh requested changes Jul 7, 2023
View reviewed changes
files/en-us/glossary/namespace/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_namespaces/index.md Outdated
The **CSS namespaces** allows authors to specify [XML namespaces](/en-US/docs/Web/SVG/Namespaces_Crash_Course) in CSS.
The **CSS namespaces** module defines the syntax for using {{glossary("namespace", "namespaces")}} in CSS.

CSS isn't just for styling HTML. A stylesheet may be used to style SVG, MathML, XML, or HTML, each of which has a different namespace or a document containing multiple namespaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CSS isn't just for styling HTML. A stylesheet may be used to style SVG, MathML, XML, or HTML, each of which has a different namespace or a document containing multiple namespaces.
CSS isn't just for styling HTML. A stylesheet may be used to style SVG, MathML, XML, or HTML, each of which has a different namespace or a document containing multiple namespaces.

files/en-us/web/css/css_namespaces/index.md Outdated Show resolved Hide resolved
dipikabh
dipikabh approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@dipikabh dipikabh merged commit 7f7ff21 into mdn:main Jul 7, 2023
6 checks passed
@estelle estelle deleted the namespacemod branch August 3, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh