Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining page-types to LA #27672

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Add remaining page-types to LA #27672

merged 3 commits into from
Jul 3, 2023

Conversation

teoli2003
Copy link
Contributor

Add page types to the remaining pages in the Learn Area.

Notes:

  • a few pages get guide page type as they are not in the IA: we will handle this IA problem in a follow-up.
  • I still need to update the meta docs for the LA; this will be in a follow-up PR today (that will close the issue)

This is part of openwebdocs/project#91 and is the first piece of #27620.

@teoli2003 teoli2003 requested a review from wbamberg June 30, 2023 06:33
@teoli2003 teoli2003 requested review from a team as code owners June 30, 2023 06:33
@teoli2003 teoli2003 requested review from Elchi3, chrisdavidmills and hidde and removed request for a team June 30, 2023 06:33
@github-actions github-actions bot added the Content:Learn Learning area docs label Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

Preview URLs (239 pages)
Flaws (30)

Note! 226 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Performance
Title: Web performance
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Learn/Performance/Fonts
    • Can't resolve /en-US/docs/Learn/Performance/Mobile

URL: /en-US/docs/Learn/Performance/CSS
Title: CSS performance optimization
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries/Using_media_queries

URL: /en-US/docs/Learn/Performance/Measuring_performance
Title: Measuring performance
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Navigation_timing_API
    • Can't resolve /en-US/docs/Web/API/Performance_API/Using_the_Performance_API
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline
    • Can't resolve /en-US/docs/Web/API/Navigation_timing_API
    • Can't resolve /en-US/docs/Web/API/User_Timing_API
    • and 1 more flaws omitted

URL: /en-US/docs/Learn/Forms/UI_pseudo-classes
Title: UI pseudo-classes
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_selectors
    • Can't resolve /en-US/docs/Web/HTML/Attributes/checked
    • Can't resolve /en-US/docs/Web/HTML/Attributes/selected

URL: /en-US/docs/Learn/Forms/Styling_web_forms
Title: Styling web forms
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout

URL: /en-US/docs/Learn/Forms/Form_validation
Title: Client-side form validation
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ValidityState/customError does not exist

URL: /en-US/docs/Learn/Forms/Sending_forms_through_JavaScript
Title: Sending forms through JavaScript
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLFormElement.elements#accessing_form_controls

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/HTML_and_CSS
Title: Handling common HTML and CSS problems
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection
Title: Implementing feature detection
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout/Subgrid
    • Can't resolve /en-US/docs/Web/API/CSS/supports
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Learn/CSS/Howto/Center_an_item
Title: How to center an item
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Box_Alignment
    • Can't resolve /en-US/docs/Web/CSS/CSS_Flexible_Box_Layout
    • Can't resolve /en-US/docs/Web/CSS/CSS_Grid_Layout
    • Can't resolve /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_in_Flexbox
    • Can't resolve /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_In_Grid_Layout

URL: /en-US/docs/Learn/Accessibility/Mobile
Title: Mobile accessibility
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Client-side_storage
Title: Client-side storage
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/URL/createObjectURL redirects to /en-US/docs/Web/API/URL/createObjectURL_static

URL: /en-US/docs/Learn/Server-side/Apache_Configuration_htaccess
Title: Apache Configuration: .htaccess
Flaw count: 2

  • heading_links:
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag

(comment last updated: 2023-07-03 10:12:36)

@teoli2003
Copy link
Contributor Author

There was a strange test error: learn/forms/how_to_build_custom_form_controls couldn't be built because yari complained about an injection flaw. I removed it from this PR (meaning it doesn't have a page type for the moment, and we'll need a follow-up: I would like not to block this PR on this problem that is unrelated to page types) (The IA structure there is also a bit different of the rest of the LA, with sub-pages embedded in it.

@github-actions github-actions bot added Content:Learn:Django Learning area Django docs Content:Learn:Express Learning area Express docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:JavaScript Learning area JavaScript docs Content:Learn:HTML Learning area HTML docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Forms Learning area Forms docs Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs Content:Learn:GitHub labels Jul 3, 2023
Elchi3
Elchi3 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you Jean-Yves! 👍

@Elchi3 Elchi3 merged commit bb026bc into mdn:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

@hidde hidde Awaiting requested review from hidde hidde is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs Content:Learn:Django Learning area Django docs Content:Learn:Express Learning area Express docs Content:Learn:Forms Learning area Forms docs Content:Learn:GitHub Content:Learn:HTML Learning area HTML docs Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @Elchi3