Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page-types to remaining pages #27785

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add page-types to remaining pages #27785

merged 2 commits into from
Jul 19, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Jul 6, 2023 •
edited
Loading

While doing the page-type project, we forgot some pages here or there (or they got added right after an area was converted without having a page-type YAML key.

This PR adds the missing page types in the 50-or-so pages that didn't have one. After this PR (and the two others still open), all MDN pages should have a page-type. (A last check will be made before closing the issue).

Note: no new page type is introduced by this PR

This is part of openwebdocs/project#91 and will close #27620.

@teoli2003 teoli2003 requested a review from Elchi3 July 6, 2023 06:55
@teoli2003 teoli2003 requested review from a team as code owners July 6, 2023 06:55
@teoli2003 teoli2003 requested review from rebloor and estelle and removed request for a team July 6, 2023 06:55
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Glossary Glossary entries Content:Games Games docs Content:Events Events docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs Content:Learn:HTML Learning area HTML docs Content:Learn:Forms Learning area Forms docs Content:PWA Progressive Web Apps content labels Jul 6, 2023
@github-actions github-actions bot removed the Content:Learn:Forms Learning area Forms docs label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Preview URLs (49 pages)
Flaws (57)

Note! 44 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/MDN/Writing_guidelines/Howto/Write_an_API_reference/Information_contained_in_a_WebIDL_file
Title: Information contained in a WebIDL file
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/WebIDL_bindings#exposed

URL: /en-US/docs/Learn/HTML/Tables/Advanced
Title: HTML table advanced features and accessibility
Flaw count: 1

  • macros:
    • The fourth to sixth parameters of 'EmbedLiveSample' are deprecated

URL: /en-US/docs/Mozilla/Firefox/Releases/3.5
Title: Firefox 3.5 for developers
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Transforms/Using_CSS_transforms
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim

URL: /en-US/docs/Mozilla/Add-ons
Title: Add-ons
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Creating_a_spell_check_dictionary_add-on

URL: /en-US/docs/Web/Events
Title: Event reference
Flaw count: 52

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/wheel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationcancel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationend_event
    • Can't resolve /en-US/docs/Web/API/Document/animationiteration_event
    • Can't resolve /en-US/docs/Web/API/Document/animationstart_event
    • and 47 more flaws omitted

estelle
estelle reviewed Jul 6, 2023
View reviewed changes
files/en-us/mdn/at_ten/history_of_mdn/index.md
@@ -1,6 +1,7 @@
---
title: The history of MDN
slug: MDN/At_ten/History_of_MDN
page-type: guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "history" a guide?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for all pages in this section

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "history" a guide?

Good question, looks like it's the best option we have at the moment: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key#generic_page_types

estelle
estelle reviewed Jul 6, 2023
View reviewed changes
files/en-us/mdn/kitchensink/index.md
@@ -1,6 +1,7 @@
---
title: The MDN Content Kitchensink
slug: MDN/Kitchensink
page-type: guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to not have a page-type on this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may use "test" as a specific page-type here.

@Josh-Cena
Copy link
Member

I suggest "meta" for the meta docs

bsmth
bsmth reviewed Jul 19, 2023
View reviewed changes
files/en-us/mdn/mdn_product_advisory_board/index.md
@@ -1,6 +1,7 @@
---
title: MDN Product Advisory Board
slug: MDN/MDN_Product_Advisory_Board
page-type: guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another one that surfaces a need to have a different page type in future, maybe. Fine for the purpose of this PR though 👍🏻

bsmth
bsmth reviewed Jul 19, 2023
View reviewed changes
files/en-us/mdn/writing_guidelines/page_structures/index.md
@@ -1,6 +1,7 @@
---
title: Page structures
slug: MDN/Writing_guidelines/Page_structures
page-type: landing-page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a landing page or a writing guide?

bsmth
bsmth approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving my +1 pending some of the (non-blocking) comments - trusting your judgement there. Thanks @teoli2003 👍🏻

@bsmth
Copy link
Member

bsmth commented Jul 19, 2023

I suggest "meta" for the meta docs

That's a good suggestion

@estelle estelle merged commit 0c16305 into mdn:main Jul 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle left review comments

@bsmth bsmth bsmth approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

@rebloor rebloor Awaiting requested review from rebloor rebloor is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:Events Events docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Games Games docs Content:Glossary Glossary entries Content:HTTP HTTP docs Content:Learn:HTML Learning area HTML docs Content:Meta Content in the meta docs Content:Other Any docs not covered by another "Content:" label Content:PWA Progressive Web Apps content Content:WebAPI Web API docs Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add page-types for the Learn Area
4 participants
@teoli2003 @Josh-Cena @bsmth @estelle