-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: css font loading #28379
New module: css font loading #28379
Conversation
Preview URLs (comment last updated: 2023-08-10 16:25:00) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @estelle; only a couple of nitpicks.
## Guides | ||
|
||
- [CSS font loading API](/en-US/docs/Web/API/CSS_Font_Loading_API) | ||
- : Overview of the CSS Font Loading API, which provide events and interfaces for dynamically loading font resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"CSS Font Loading API" -> "CSS font loading API" for consistency on this page, based on the fact that it isn't actually an official name, but something we're calling the DOM API part of the CSS Font Loading Module? I'm not sure if you want to change naming instances on the linked page too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS URLs are lower case, we having updating the API urls yet
- CSS {{cssxref("@font-face")}} at-rule | ||
- CSS {{cssxref("@font-feature-values")}} at-rule | ||
- {{domxref("CSSFontFaceRule")}} interface | ||
- Document {{domxref("document.fonts", "fonts")}} property (returns the {{domxref("fontFaceSet")}} interface) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"returns the {{domxref("fontFaceSet")}} interface" -> "returns a {{domxref("FontFaceSet")}} object instance", given that it isn't the interface that's returned, but an instance of the object defined by the class? Same nitpick for the line below too.
New CSS module
Title: CSS font loading
Spec: https://drafts.csswg.org/css-font-loading/
fixes: openwebdocs/project#177
part of openwebdocs/project#176