Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: css font loading #28379

Merged
merged 3 commits into from
Aug 10, 2023
Merged

New module: css font loading #28379

merged 3 commits into from
Aug 10, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 3, 2023

New CSS module

Title: CSS font loading
Spec: https://drafts.csswg.org/css-font-loading/
fixes: openwebdocs/project#177
part of openwebdocs/project#176

@estelle estelle requested a review from a team as a code owner August 3, 2023 23:12
@estelle estelle requested review from chrisdavidmills and removed request for a team August 3, 2023 23:12
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Preview URLs

(comment last updated: 2023-08-10 16:25:00)

@estelle estelle requested a review from dipikabh August 10, 2023 00:38
@dipikabh dipikabh self-assigned this Aug 10, 2023
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @estelle; only a couple of nitpicks.

## Guides

- [CSS font loading API](/en-US/docs/Web/API/CSS_Font_Loading_API)
- : Overview of the CSS Font Loading API, which provide events and interfaces for dynamically loading font resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"CSS Font Loading API" -> "CSS font loading API" for consistency on this page, based on the fact that it isn't actually an official name, but something we're calling the DOM API part of the CSS Font Loading Module? I'm not sure if you want to change naming instances on the linked page too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS URLs are lower case, we having updating the API urls yet

files/en-us/web/css/css_font_loading/index.md Show resolved Hide resolved
- CSS {{cssxref("@font-face")}} at-rule
- CSS {{cssxref("@font-feature-values")}} at-rule
- {{domxref("CSSFontFaceRule")}} interface
- Document {{domxref("document.fonts", "fonts")}} property (returns the {{domxref("fontFaceSet")}} interface)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"returns the {{domxref("fontFaceSet")}} interface" -> "returns a {{domxref("FontFaceSet")}} object instance", given that it isn't the interface that's returned, but an instance of the object defined by the class? Same nitpick for the line below too.

@estelle estelle merged commit fe5361c into mdn:main Aug 10, 2023
6 checks passed
@estelle estelle deleted the fontLoading branch August 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Modue: font loading
3 participants