Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CSS data-type: generic family #28405

Merged
merged 14 commits into from
Aug 8, 2023
Merged

New CSS data-type: generic family #28405

merged 14 commits into from
Aug 8, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 5, 2023

@estelle estelle requested a review from a team as a code owner August 5, 2023 00:36
@estelle estelle requested review from chrisdavidmills and removed request for a team August 5, 2023 00:36
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-08-08 07:44:50)

chrisdavidmills
chrisdavidmills requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle looking good! I have made a few comments, but nothing major.

files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/generic-family/index.md Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessssss, perfect. Approving!

@chrisdavidmills chrisdavidmills merged commit bdcace5 into mdn:main Aug 8, 2023
6 checks passed
@estelle estelle deleted the generic-family branch August 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills