Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated font-tech in @supports #28597

Merged
merged 7 commits into from
Aug 17, 2023
Merged

updated font-tech in @supports #28597

merged 7 commits into from
Aug 17, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 16, 2023 •
edited
Loading

@estelle estelle requested a review from a team as a code owner August 16, 2023 22:38
@estelle estelle requested review from dipikabh and removed request for a team August 16, 2023 22:38
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 16, 2023
@estelle estelle marked this pull request as draft August 16, 2023 22:38
@estelle estelle marked this pull request as ready for review August 16, 2023 22:39
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/font-variant-ligatures
Title: font-variant-ligatures
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/contextual_forms does not exist

URL: /en-US/docs/Web/CSS/@supports
Title: @supports
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/CSS/supports redirects to /en-US/docs/Web/API/CSS/supports_static

(comment last updated: 2023-08-17 15:04:49)

github-actions[bot]
github-actions bot reviewed Aug 16, 2023
View reviewed changes
files/en-us/web/css/@supports/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@supports/index.md Outdated Show resolved Hide resolved
@estelle @github-actions
Apply suggestions from code review
f7b938c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Aug 16, 2023
View reviewed changes
files/en-us/web/css/@supports/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@supports/index.md Outdated Show resolved Hide resolved
estelle and others added 2 commits August 16, 2023 15:50
@estelle
font-variant-ligatures (#28598)
825986b
@estelle @github-actions
Apply suggestions from code review
b857273 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dipikabh
dipikabh requested changes Aug 17, 2023
View reviewed changes
files/en-us/web/css/@supports/index.md Outdated Show resolved Hide resolved
dipikabh
dipikabh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle. Updates are good. I took the liberty of committing minor changes.

@dipikabh dipikabh merged commit 557f7fc into main Aug 17, 2023
7 checks passed
@dipikabh dipikabh deleted the estelle-patch-1 branch August 17, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh