-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 22887: Rewrite web components guide #29252
Conversation
Preview URLs External URLs (6)URL:
(comment last updated: 2023-09-25 22:27:03) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @wbamberg; this is looking much improved, and it largely makes sense. I just had a few comments for you to respond to.
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/web_components/using_custom_elements/index.md
Outdated
Show resolved
Hide resolved
Thank for for the review Chris! Updates are in f36ea54. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, cheers @wbamberg!
Fixes #22887, I hope.
This ended up being much more involved than I was anticipating. As #22887 (comment) pointed out, if we want to use
connectedCallback()
we have to reorganize things so as to introduce that first. And once I started doing that it seemed like it would be cleaner to do all the explaining and then have the examples. I wish that mdn/yari#7198 were fixed, so the example titles appeared in the ToC.Anyway, I hope this all still makes sense. I don't know much about web components. @chrisdavidmills , would you mind taking a look?
Oh BTW there will be a corresponding PR in https://github.com/mdn/web-components-examples.