Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22887: Rewrite web components guide #29252

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Sep 22, 2023

Fixes #22887, I hope.

This ended up being much more involved than I was anticipating. As #22887 (comment) pointed out, if we want to use connectedCallback() we have to reorganize things so as to introduce that first. And once I started doing that it seemed like it would be cleaner to do all the explaining and then have the examples. I wish that mdn/yari#7198 were fixed, so the example titles appeared in the ToC.

Anyway, I hope this all still makes sense. I don't know much about web components. @chrisdavidmills , would you mind taking a look?

Oh BTW there will be a corresponding PR in https://github.com/mdn/web-components-examples.

@github-actions github-actions bot added the Content:WebAPI Web API docs label Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Preview URLs

External URLs (6)

URL: /en-US/docs/Web/API/Web_components/Using_custom_elements
Title: Using custom elements

(comment last updated: 2023-09-25 22:27:03)

@wbamberg wbamberg marked this pull request as ready for review September 22, 2023 22:29
@wbamberg wbamberg requested a review from a team as a code owner September 22, 2023 22:29
@wbamberg wbamberg requested review from sideshowbarker, chrisdavidmills and a team and removed request for a team and sideshowbarker September 22, 2023 22:29
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @wbamberg; this is looking much improved, and it largely makes sense. I just had a few comments for you to respond to.

@wbamberg
Copy link
Collaborator Author

Thank for for the review Chris! Updates are in f36ea54.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, cheers @wbamberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs say attach shadow root in connectedCallback, example has it in constructor
2 participants