-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a case to the warning #2965
Conversation
@keePeek can you please update the description to provide a summary of your changes? You've ticked the checklist box, but you've not added a description of what you are doing here and why. Thanks! |
Obviously the first input box ( Why is it so troublesome after MDN switched to GitHub? I used to directly contribute and edit a few pages on the MDN website, and it was quite simple and easy at that time, just like Wikipedia or StackOverflow, but now it is more cumbersome (at least five more steps) to contribute to MDN! |
I got confused because you used the word "case" in your title, so it made me think your addition was supposed to be something about string casing. But I guess you mean it in a more general sense.
I can underatand your frustration. It is always a pain to get used to a new workflow. But for simple changes I don't think it is any more complex than the old Wiki system. You are able to just go to the source page in GitHub, press the little "Edit this file" button, make your changes, and then submit a PR right from the Web UI. For larger changes, it is better to set up the local Yari installation as detailed in the README. And there are so many advantages to the new system, like proper reviewing, mass edits, community communication, and more. |
So, is there anything else I need to do? Is there still something unreasonable in my submission? |
Your submission hasn't been reviewd yet. There reviewer has been set to @Rumyra , and she will get to it soon, I'm sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @keePeek thank you! Just a minor update to include a link to lastIndex 👍
files/en-us/web/javascript/reference/global_objects/regexp/exec/index.html
Show resolved
Hide resolved
Hi @keePeek if you commit the above suggestions we should be able to get this merged - thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rumyra Please review and merge the revised latest full text I attached below (replace all the source code I submitted before).
files/en-us/web/javascript/reference/global_objects/regexp/exec/index.html
Show resolved
Hide resolved
@Rumyra Ping |
Hi @keePeek this looks great, if you can add it to this PR that would also be great - thank you 🙏 |
|
||
<p>In addition, when matching zero-length characters (e.g. <code>/^/gm</code>), | ||
<code>++regexp.lastIndex</code> can be used to avoid infinite loops.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>In addition, when matching zero-length characters (e.g. <code>/^/gm</code>), | |
<code>++regexp.lastIndex</code> can be used to avoid infinite loops.</p> | |
<p>In addition, when matching zero-length characters (e.g. <code>/^/gm</code>), | |
increase its {{jsxref("RegExp.lastIndex", "lastIndex")}} each time to avoid | |
an infinite loop.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification is of course the final version! 🙏 Plz merge, thx!~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just realized that the previous collaboration failure should be blamed on me for not knowing the meaning of "Resolve conversation", I shouldn't click this button. Sorry everyone (with embarrassment)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing for lack of response from OP |
This comment has been minimized.
This comment has been minimized.
Hi @keePeek you should see a 'Commit Suggestion' button when viewing this issue (only the PR owner can see it) If you click that we should be able to get this merged 👍 |
Checklist — To help your pull request get merged faster, please do following: