-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Counters Module #29669
CSS Counters Module #29669
Conversation
Preview URLs
External URLs (1)URL:
(comment last updated: 2023-10-24 01:39:00) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these pages, @estelle! 🙌
I've added my edit suggestions as well as some questions.
- [`<counter-style>`](/en-US/docs/Web/CSS/@counter-style#counter-style-name) | ||
- [`<counter-style-name>`](/en-US/docs/Web/CSS/@counter-style#counter-style-name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- These two types do not have corresponding pages yet, correct?
- Also note that they both have the same link
- The Formal syntax section and the spec only refer to
<counter-style-name>
out of the two. Is<counter-style>
needed? - Do we need to add
<declaration-list>
since it is in the Formal syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
declaration list is not defined by this spec, but i did define it in one sentence on the page that uses it.
counter-style removed. good catch
counter style name does not have its own page.
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Thanks @dipikabh for the excellent review. I think I captured all the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and clarifying notes. I've pointed a few last nits.
{{Compat}} | ||
- [CSS generated content](/en-US/docs/Web/CSS/CSS_generated_content) module | ||
- [CSS pseudo-elements](/en-US/docs/Web/CSS/CSS_pseudo-elements) module | ||
- [Ready-made counter styles](https://w3c.github.io/predefined-counter-styles/) via W3C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document, the Editor's Draft, has a date at the top. I think it might be good to note the year for this version of the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ EmbedLiveSample('Extends_example') }}
will need to be updated to
{{ EmbedLiveSample('Extending_a_counter') }}
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dipikabh Thanks for the review. I think we're good to go. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking if this can resolve the lint error
@counter-styles
to remove history