Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter descriptor: range #29819

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Counter descriptor: range #29819

merged 4 commits into from
Oct 26, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 24, 2023

@estelle estelle requested a review from a team as a code owner October 24, 2023 20:08
@estelle estelle requested review from chrisdavidmills and removed request for a team October 24, 2023 20:08
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-10-26 16:33:27)

chrisdavidmills
chrisdavidmills approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle nice work; just a couple of small suggestions for you to look at.

files/en-us/web/css/@counter-style/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/range/index.md Outdated Show resolved Hide resolved
@estelle @chrisdavidmills
Apply suggestions from code review
0eac8da 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle enabled auto-merge (squash) October 26, 2023 16:29
@estelle estelle merged commit de3ff1d into mdn:main Oct 26, 2023
6 checks passed
@estelle estelle deleted the counterrange branch December 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills