-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(css): add module page for CSS Properties and Values API #30503
Conversation
* link to guides and module pages
Preview URLs (8 pages)Flaws (2)Note! 6 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLs (1)URL:
(comment last updated: 2023-12-18 13:55:46) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.See https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/CSS_module_landing_page_template for the css module landing page template.
files/en-us/web/api/css_properties_and_values_api/guide/index.md
Outdated
Show resolved
Hide resolved
…oc conventions for module pages
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review (up thru css cascading values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more feedback
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
several suugestions. all minor. we're close.
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Thanks! 🎉
Super, thanks 🎉 |
* docs(css): add module page for CSS Properties and Values API * link to guides and module pages * docs(css): remove unnecessary string identifier * docs(css): fix flaws in module pages * docs(css): check-in changes, remove unnecessary styles * docs(css): changes following reviewer feedback, conform to existing doc conventions for module pages * Apply suggestions from code review Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * docs(css): changes following reviewer feedback, make hidden examples a single block * docs(css): changes following reviewer feedback * docs(css): changes following reviewer feedback * Update files/en-us/web/css/css_cascading_variables/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * docs(css): changes following reviewer feedback * docs(css): changes following reviewer feedback * Apply suggestions from code review Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Fix typos Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs(css): Move 'syntax strings' up into syntax DL * docs(css): Improvements following reviewer feedback * Update files/en-us/web/css/css_properties_and_values_api/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Apply suggestions from code review Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * docs(css): Correct internal xrefs to use locale / root relative * docs(css): Improvements following reviewer feedback --------- Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Add a new module landing page for CSS Properties and Values API.
other changes:
Motivation
With the addition of
@property
, there's a need to differentiate between--*
-> https://drafts.csswg.org/css-variables