CSS content update: learn to support older browsers #31473

estelle · 2024-01-03T00:16:16Z

remove grid / float fallback example (outdated)
add lingo about evergreen
add browser error handling
change PNG to include a BCD live example instead

In combo with #31387 and openwebdocs/project#188

github-actions · 2024-01-03T00:17:47Z

Preview URLs

/en-US/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers

External URLs (1)

URL: /en-US/docs/Learn/CSS/CSS_layout/Supporting_Older_Browsers
Title: Supporting older browsers

https://gs.statcounter.com/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-01-12 22:46:01)

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

dipikabh · 2024-01-05T03:58:13Z

Hi @estelle, let me know if this is ready to review. The title says "Draft"

estelle · 2024-01-09T06:06:23Z

@dipikabh This is ready. It could likely be deleted altogether, but that would require changes to every page in the CSS layout section, so I edited it instead.

dipikabh

Hi @estelle, I finished a readthrough of the changed text. I've added my suggestions and some questions.

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

…ex.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dipikabh

Almost there, just a few more edits and flaws to be fixed

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

dipikabh · 2024-01-12T16:32:10Z

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md


-{{ EmbedLiveSample('Falling_back_from_grid_to_float', '100%', '200') }}
+These techniques were demonstrated in the [legacy techniques layout tutorial](/en-US/docs/Learn/CSS/CSS_layout/Legacy_Layout_Methods). Back when grid wasn't fully supported, the browser ignored the grid styles. This tutorial is now a good demonstration of how newer features, in this case grid layout, are designed and defined to take precedence over older features, floats in this case, when their effects would have otherwise conflicted.


I guess we removed this para?

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

estelle · 2024-01-12T20:10:03Z

thanks @dipikabh

Also, yes, I removed the paragraph linking to legacy layouts as the explanation that was the reason for the link is no longer on that page.

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md

dipikabh

Thanks for your work on updating this page, @estelle 🎉

* supporting older browsers page * remove more legacy cruft * typo * changes the entire see also * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * Update files/en-us/learn/css/css_layout/supporting_older_browsers/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * rewrote selector section * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * fix typo --------- Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

supporting older browsers page

868c12b

estelle requested a review from a team as a code owner January 3, 2024 00:16

estelle requested review from dipikabh and removed request for a team January 3, 2024 00:16

estelle marked this pull request as draft January 3, 2024 00:16

github-actions bot added the Content:Learn:CSS Learning area CSS docs label Jan 3, 2024

estelle changed the title ~~CSS content update: learn to support older browsers~~ Draft: CSS content update: learn to support older browsers Jan 3, 2024

estelle marked this pull request as ready for review January 3, 2024 00:17

dawei-wang reviewed Jan 3, 2024

View reviewed changes

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md Outdated Show resolved Hide resolved

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md Outdated Show resolved Hide resolved

dipikabh self-assigned this Jan 5, 2024

estelle added 2 commits January 8, 2024 22:03

remove more legacy cruft

d2df6fc

typo

0bf8f1c

estelle changed the title ~~Draft: CSS content update: learn to support older browsers~~ CSS content update: learn to support older browsers Jan 9, 2024

estelle and others added 2 commits January 10, 2024 11:30

Merge branch 'main' into guides

76f4169

changes the entire see also

5f90f58

dipikabh requested changes Jan 10, 2024

View reviewed changes

estelle and others added 2 commits January 10, 2024 18:00

Apply suggestions from code review

e66e877

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

Apply suggestions from code review

68c0178

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

github-actions bot reviewed Jan 11, 2024

View reviewed changes

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md Outdated Show resolved Hide resolved

estelle and others added 2 commits January 10, 2024 18:17

Update files/en-us/learn/css/css_layout/supporting_older_browsers/ind…

172b93a

…ex.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

rewrote selector section

4abbc9f

estelle requested a review from dipikabh January 12, 2024 00:03

dipikabh requested changes Jan 12, 2024

View reviewed changes

Apply suggestions from code review

60a308e

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

estelle requested a review from dipikabh January 12, 2024 20:10

dipikabh requested changes Jan 12, 2024

View reviewed changes

files/en-us/learn/css/css_layout/supporting_older_browsers/index.md Outdated Show resolved Hide resolved

fix typo

eebded0

dipikabh approved these changes Jan 12, 2024

View reviewed changes

dipikabh merged commit e308781 into mdn:main Jan 12, 2024
7 checks passed

estelle deleted the guides branch March 26, 2024 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSS content update: learn to support older browsers #31473

CSS content update: learn to support older browsers #31473

estelle commented Jan 3, 2024

github-actions bot commented Jan 3, 2024 •

edited

Loading

dipikabh commented Jan 5, 2024

estelle commented Jan 9, 2024

dipikabh left a comment

dipikabh left a comment

dipikabh Jan 12, 2024

estelle commented Jan 12, 2024

dipikabh left a comment


		{{ EmbedLiveSample('Falling_back_from_grid_to_float', '100%', '200') }}
		These techniques were demonstrated in the [legacy techniques layout tutorial](/en-US/docs/Learn/CSS/CSS_layout/Legacy_Layout_Methods). Back when grid wasn't fully supported, the browser ignored the grid styles. This tutorial is now a good demonstration of how newer features, in this case grid layout, are designed and defined to take precedence over older features, floats in this case, when their effects would have otherwise conflicted.

CSS content update: learn to support older browsers #31473

CSS content update: learn to support older browsers #31473

Conversation

estelle commented Jan 3, 2024

github-actions bot commented Jan 3, 2024 • edited Loading

dipikabh commented Jan 5, 2024

estelle commented Jan 9, 2024

dipikabh left a comment

Choose a reason for hiding this comment

dipikabh left a comment

Choose a reason for hiding this comment

dipikabh Jan 12, 2024

Choose a reason for hiding this comment

estelle commented Jan 12, 2024

dipikabh left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2024 •

edited

Loading