Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span element to sample code #3224

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

ryan-villena
Copy link
Contributor

@ryan-villena ryan-villena commented Mar 17, 2021

Checklist — To help your pull request get merged faster, please do the following:

    • Provide a summary of your changes — say what problem you are fixing, what files are changed, and what you've done. This doesn't need to be hugely detailed, as we can see exact changes in the "Files changed" tab.
    • Provide a link to the issue(s) you are fixing, if appropriate, in the form "Fixes url-of-issue". GitHub will render this in the form "Fixes fix: fixable flaws in Glossary A-D entries #1234", with the issue number linked to the issue. Doing this allows us to figure out what issues you are fixing, as well as helping to automate things (for example the issue will be closed once the PR that fixed it has been merged).
    • Review the results of the automated checking we run on every PR and fix any problems reported (see the list of checks near the bottom of the PR page). If you need help, please ask in a comment!
    • Link to any other resources that you think might be useful in reviewing your PR.

An exercise has the student creating a rule which would affect one out of two <span> elements in the sample code. If the student is working locally having copied the sample code from the top of the page (instead of using the embedded live example), they are missing one of the <span> elements involved in the exercise. This fixes that issue.

No Issue to link to that I could find, possible I could have missed it though. Please let me know if I should have written one; I didn't see that it was required in the contribution guide, and this seemed simple enough a fix.

@ryan-villena ryan-villena requested review from a team and rachelandrew and removed request for a team March 17, 2021 08:51
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rachelandrew rachelandrew merged commit f7f189e into mdn:main Mar 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants