Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topic selection algorithm information based on recent Chrome changes #32441

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

As per #30107 (comment), Chrome recently changed the way that it selects topics for each epoch in the Topics API.

This PR updates that description so it is current.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner February 26, 2024 11:40
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team February 26, 2024 11:40
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Feb 26, 2024
@chrisdavidmills
Copy link
Contributor Author

cc @samdutton

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Preview URLs

Flaws (6)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • /en-US/docs/Web/API/Document/getBoxQuads does not exist
    • /en-US/docs/Web/API/Document/releaseEvents does not exist
    • /en-US/docs/Web/API/Document/queryCommandIndeterm does not exist
    • and 1 more flaws omitted
External URLs (1)

URL: /en-US/docs/Web/API/Topics_API/Using
Title: Using the Topics API

(comment last updated: 2024-02-28 18:27:56)

Copy link

@samdutton samdutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments on "current epoch", etc.

Changed top-topics algorithm content LGTM.

files/en-us/web/api/document/browsingtopics/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
Copy link

@samdutton samdutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few suggestions.

files/en-us/web/api/document/browsingtopics/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/browsingtopics/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/using/index.md Outdated Show resolved Hide resolved
Copy link

@samdutton samdutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks!

@chrisdavidmills
Copy link
Contributor Author

Tech review finished; great, thanks @samdutton

@wbamberg, would you be OK to have a quick look at this one for final approval; some small wording changes.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Feb 28, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Feb 28, 2024
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Chris!

@wbamberg wbamberg merged commit 1df8a66 into mdn:main Feb 28, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the topics-api-tweaks branch February 29, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants