-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update topic selection algorithm information based on recent Chrome changes #32441
Conversation
cc @samdutton |
Preview URLs
Flaws (6)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2024-02-28 18:27:56) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments on "current epoch", etc.
Changed top-topics algorithm content LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — thanks!
Tech review finished; great, thanks @samdutton @wbamberg, would you be OK to have a quick look at this one for final approval; some small wording changes. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you Chris!
Description
As per #30107 (comment), Chrome recently changed the way that it selects topics for each epoch in the Topics API.
This PR updates that description so it is current.
Motivation
Additional details
Related issues and pull requests