Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editorial review: Add content to cover the field-sizing property #32489
feat: Editorial review: Add content to cover the field-sizing property #32489
Changes from 32 commits
407486e
aa9e585
7520717
a3e673f
9f3836e
18254e0
7f98011
164e3f4
e9995fd
92b7638
ca80094
4e7443b
cebb994
c186046
aa6a637
0484cd7
81dddbb
5e047e7
b1043f9
c61efd3
20291f4
1745909
c38c022
59a2d73
ebc8641
48af99f
b036c3c
03c6d9f
1537fb9
dce3098
d3b3ec7
ac22169
af7896d
c28ee15
a9552bd
76b7ee9
4098ede
b19cbbd
76e3d95
ad2543f
05fe9d9
726496c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should note that this is the browser default for elements with default preferred size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, however, I've just added "This is the default value." If you look at the computed values on any element, a default
field-sizing: fixed
will be shown.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to clarify that this is ifIf we change the h3 heading to "Elements affected bycontent
is set. Not true iffixed
is set, where the size is set by thesize
attribute or the browser's default preferred size.field-sizing: content
and intro statement this edit is not needed, and the multiple "elements withfield-sizing: content
set" can be removed from bullets below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the heading change, however, I think most of those instances are still needed — the sentences read a bit strangely when removed, and some of them are important so that the sentence makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it still convey the same intended meaning if we rephrase it like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't feel like this was quite accurate, so I changed it to this:
Does that work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, yes, this is good! Did we get rid of the colons? I think they were good to have