-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composable function typos. Clarify wording. #3252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree that the current text here is very unclear. I had a couple of suggestions though - in particular I don't think technical writing should ever call something "simple" as a general judgement.
files/en-us/web/javascript/reference/global_objects/array/reduceright/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/reduceright/index.html
Outdated
Show resolved
Hide resolved
…ceright/index.html Co-authored-by: wbamberg <will@bootbonnet.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a couple of final changes:
- we use sentence case "Defining composable functions" rather than title case "Defining Composable Functions"
- removed the code comment and integrated the Wikipedia link
Thanks for your work on this PR @manzaloros , it's a real improvement to the docs!
Thank you, @wbamberg , I appreciate your compliment and your help. |
Summary of changes:
Checklist — To help your pull request get merged faster, please do the following: