Iss1410

[CreaTorAlexander]

Fixes #1410

Instead of using the onclick html attribute here we use an eventlistener

I don't know why the other commit with #2658 is here it should already merged, but idk how to remove this commit.

[chrisdavidmills]

@CreaTorAlexander there are a couple of problems here, and this code snippet won't work as it stands:

1. Document.querySelector() doesn't take a second argument of a function to invoke. You'd have to do this using something like addEventListener() instead.
2. addAttribute() doesn't exist — setAttribute() is what you need.

the following works:

const btn = document.querySelector('button');
btn.addEventListener('click', triggerAlert);

function triggerAlert() {
  var alertEl = document.querySelector('.alert');
  console.log(alertEl)
  alertEl.setAttribute('role', 'alert');
}

Make sure you test code snippets before submitting.

[CreaTorAlexander]

Damn sorry, did it in the GitHub UI what was obviously here a mistake.
I will update it later on.

[chrisdavidmills]

Damn sorry, did it in the GitHub UI what was obviously here a mistake.
I will update it later on.

No need to apologize at all. We all make mistakes sometimes, and what you do for us is hugely helpful.

[CreaTorAlexander]

@chrisdavidmills is there a reason for the console.log?

[chrisdavidmills]

@chrisdavidmills is there a reason for the console.log?

Oh, no, there isn't! That was leftover from a test I did. you can remove that ;-)

[CreaTorAlexander]

Okay, I assumed it so I already did a PR. #3270