Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated Sanitizer API content #33141

Closed
wants to merge 1 commit into from

Conversation

lukewarlow
Copy link
Contributor

Description

Removes content for unshipped and out of date Sanitizer API spec.

Motivation

In their current form these documents are more confusing than helpful, and the API shape has changed a large amount since written. As a result they'd need to be almost fully rewritten anyway.

Additional details

Related issues and pull requests

Relates to #32731

@lukewarlow lukewarlow requested a review from a team as a code owner April 17, 2024 18:57
@lukewarlow lukewarlow requested review from Elchi3 and removed request for a team April 17, 2024 18:57
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 17, 2024
Copy link
Contributor

github-actions bot commented Apr 17, 2024

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Element
Title: Element
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Element/getBoxQuads does not exist
External URLs (5)

URL: /en-US/docs/Web/API/Element
Title: Element


URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element: innerHTML property

(comment last updated: 2024-04-18 11:42:46)

@lukewarlow
Copy link
Contributor Author

Flaws are unrelated to this change but happy to fix them.

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001
Copy link
Contributor

the api entry in files/jsondata/GroupData.json also seems to need to remove

image

@hamishwillee
Copy link
Collaborator

In their current form these documents are more confusing than helpful, and the API shape has changed a large amount since written. As a result they'd need to be almost fully rewritten anyway.

While this is true, it is contrary to MDN policy. MDN follows BCD. BCD policy is that if something has been in the web platform, it gets removed after 2 years. Given that Chrome removed this in 119 we're a long way from that.

I don't think we should change our policy for any one case. But since you're right, we should start by making this all as deprecated in BCD.

@hamishwillee
Copy link
Collaborator

P.S. Though if there is a replacement API appearing in browsers, then it might be OK to remove much of this.

@lukewarlow
Copy link
Contributor Author

Okay I'll close this for now then

@hamishwillee
Copy link
Collaborator

Okay I'll close this for now then

Thanks @lukewarlow. I've added deprecated to the BCD which should help a bit. Maybe we'll get lucky and be allowed to delete the content some point soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants