Ff126 Selection.direction and Selection.getComposedRange #33223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
8 tasks
|
Preview URLs
(comment last updated: 2024-05-07 21:38:28) |
hamishwillee
force-pushed
the
ff126_selection_direction_etc
branch
from
b8789f2
to
86d9366
Compare
sideshowbarker
approved these changes
May 7, 2024
Co-authored-by: sideshowbarker <mike@w3.org>
|
Thanks for the review @sideshowbarker . I'm going to merge this now and do further work on a new PR on Friday. Much appreciated. |
dalps
pushed a commit
to dalps/content
that referenced
this pull request
May 8, 2024
* Selection.direction - add doc * Fixes to direction * Selection.getComposedRanges() - initial docs * Update getComposeRanges * Add getRangeAt info that you can't trust it * Apply suggestions from code review Co-authored-by: sideshowbarker <mike@w3.org> --------- Co-authored-by: sideshowbarker <mike@w3.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF has added support for the Selection.direction and Selection.getComposedRange (as has Safari). This adds docs for both.
It would be good to get this in as is, so there is something in place for a release.
I do still plan to add more examples for
Selection.getComposedRange(), showing things like how it works with a web components, and perhaps slots (these are covered in the explainer).Related docs work in: #33180