Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS modules: CSS table #33236

Merged
merged 12 commits into from
Apr 25, 2024
Merged

CSS modules: CSS table #33236

merged 12 commits into from
Apr 25, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 23, 2024

  • made the table module follow the newish template guidelines
  • added links to the module to the five table related properties.

@estelle estelle requested a review from a team as a code owner April 23, 2024 13:10
@estelle estelle requested review from dipikabh and removed request for a team April 23, 2024 13:10
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Preview URLs (6 pages)
Flaws (1)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_table
Title: CSS table
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing
External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_table
Title: CSS table

(comment last updated: 2024-04-25 16:23:59)

@dipikabh dipikabh self-assigned this Apr 23, 2024
dipikabh
dipikabh requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @estelle. I’ve suggested some edits and have a few questions for you to consider.

files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md
- {{cssxref("border")}} shorthand
- {{cssxref("border-width")}}
- {{cssxref("border-style")}}
- {{cssxref("border-color")}}

## Specifications

{{Specifications}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace the spec-urls front matter key value with "https://drafts.csswg.org/css-tables-3/", the same spec link that you're also using in the note after the Specifications table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note below: the spec is not ready for implementation, and has a big orange warning when you visit the page, so opting not to update the spec-url.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that in the Specifications table, we link to "Cascading Style Sheets Level 2 Revision 2 (CSS 2.2) Specification", but in the note we link to "CSS Table Module Level 3 specification". Seems disjointed. I've added a rewording suggestion for the note.

files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md
- {{htmlelement("th")}}
- {{htmlelement("td")}}

- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module
- [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was correct. See #33182

estelle
estelle commented Apr 23, 2024
View reviewed changes
Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @dipikabh.

I committed most of your changes, and commented on those I did not commit.

files/en-us/web/css/css_table/index.md
- {{htmlelement("th")}}
- {{htmlelement("td")}}

- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was correct. See #33182

files/en-us/web/css/css_table/index.md
- {{cssxref("border")}} shorthand
- {{cssxref("border-width")}}
- {{cssxref("border-style")}}
- {{cssxref("border-color")}}

## Specifications

{{Specifications}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note below: the spec is not ready for implementation, and has a big orange warning when you visit the page, so opting not to update the spec-url.

files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from dipikabh April 23, 2024 23:16
estelle and others added 4 commits April 23, 2024 16:17
@estelle @dipikabh
Apply suggestions from code review
ce3bfaf 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
trying again. will it take?
d3278cc 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
Merge branch 'main' into table
efaac97
@estelle
move html down
03fb0fc
estelle and others added 3 commits April 24, 2024 07:45
@estelle
Merge branch 'main' into table
d18abfe
@estelle
lint
0785c11
@estelle @github-actions
Update files/en-us/web/css/css_table/index.md
3d74910 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle @github-actions
Update files/en-us/web/css/css_table/index.md
60ac40c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dipikabh
dipikabh reviewed Apr 25, 2024
View reviewed changes
files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_table/index.md
- {{cssxref("border")}} shorthand
- {{cssxref("border-width")}}
- {{cssxref("border-style")}}
- {{cssxref("border-color")}}

## Specifications

{{Specifications}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that in the Specifications table, we link to "Cascading Style Sheets Level 2 Revision 2 (CSS 2.2) Specification", but in the note we link to "CSS Table Module Level 3 specification". Seems disjointed. I've added a rewording suggestion for the note.

dipikabh
dipikabh approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, @estelle! Leaving a +1 with one suggestion outstanding to possibly reword the "Note".

estelle and others added 2 commits April 25, 2024 09:22
@estelle @dipikabh
Update files/en-us/web/css/css_table/index.md
7401320 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
Update files/en-us/web/css/css_table/index.md
4b64ca6 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle merged commit b319e19 into mdn:main Apr 25, 2024
8 checks passed
@estelle estelle deleted the table branch April 25, 2024 16:23
@estelle estelle mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh