Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect references in markerUnits docs #3376

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

atdyer
Copy link
Contributor

@atdyer atdyer commented Mar 22, 2021

The markerUnits attribute defines the coordinate system for the markerWidth and markerHeight attributes, not markerWidth and markerUnits as is currently reflected in the docs. This commit changes the docs to match the SVG 1.1 and SVG 2 specs.

Checklist — To help your pull request get merged faster, please do the following:

    • Provide a summary of your changes — say what problem you are fixing, what files are changed, and what you've done. This doesn't need to be hugely detailed, as we can see exact changes in the "Files changed" tab.
    • Provide a link to the issue(s) you are fixing, if appropriate, in the form "Fixes url-of-issue". GitHub will render this in the form "Fixes fix: fixable flaws in Glossary A-D entries #1234", with the issue number linked to the issue. Doing this allows us to figure out what issues you are fixing, as well as helping to automate things (for example the issue will be closed once the PR that fixed it has been merged).
    • Review the results of the automated checking we run on every PR and fix any problems reported (see the list of checks near the bottom of the PR page). If you need help, please ask in a comment!
    • Link to any other resources that you think might be useful in reviewing your PR.

The markerUnits attribute defines the coordinate system for the markerWidth and markerHeight attributes, not markerWidth and markerUnits. This commit changes the docs to match the [SVG 1.1](https://www.w3.org/TR/SVG11/painting.html#MarkerUnitsAttribute) and [SVG 2](https://svgwg.org/svg2-draft/painting.html#MarkerUnitsAttribute) specs.
@atdyer atdyer requested a review from a team March 22, 2021 16:59
@sideshowbarker sideshowbarker merged commit 3ecd86f into mdn:main Mar 23, 2021
@sideshowbarker
Copy link
Collaborator

Tristan, thanks much for catching this and fixing it, and congrats on landing your first docs change here — welcome aboard 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants