Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that navigator.storage.persist() depends on heuristics #33780

Merged
merged 2 commits into from
May 28, 2024

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented May 27, 2024

Description

Add a note about heuristics.

Motivation

It confuses users when this request doesn't get honored.

Additional details

https://web.dev/articles/persistent-storage#chrome_and_other_chromium-based_browsers.

Related issues and pull requests

@tomayac tomayac requested a review from a team as a code owner May 27, 2024 15:25
@tomayac tomayac requested review from Elchi3 and removed request for a team May 27, 2024 15:25
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels May 27, 2024
Copy link
Contributor

github-actions bot commented May 27, 2024

Preview URLs

(comment last updated: 2024-05-28 07:52:52)

Co-authored-by: wbamberg <will@bootbonnet.ca>
@tomayac tomayac requested a review from wbamberg May 28, 2024 07:51
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomayac and @wbamberg 👍

@Elchi3 Elchi3 merged commit 7b6769c into mdn:main May 28, 2024
8 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request May 28, 2024
* upstream/main: (55 commits)
  Replace `.` with `#` in example given selectors are `#ids` (mdn#33791)
  update info in cross browser testing strategies (mdn#33730)
  Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780)
  fix typo (mdn#33785)
  feat: improvements on Glossary/Hoisting (mdn#33787)
  CSS update: overview of shapes guide (mdn#33771)
  CSS update: Shapes from box values (mdn#33770)
  Fix issue 033506: correct droppedEntriesCount (mdn#33538)
  Revert "=== Symbol("foo")" (mdn#33782)
  docs(css): FF126 - Support for `shape()` function (mdn#33446)
  Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777)
  Bump ajv from 8.13.0 to 8.14.0 (mdn#33776)
  Add missing spaces for `subtlecrypto` (mdn#33774)
  fix: typo in `color_and_luminca` (mdn#33775)
  feat: improvments on gutters (mdn#33751)
  FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738)
  update the content of SVG `<view>` element (mdn#33710)
  Clipboard.write() - log and fixes (mdn#33769)
  updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262)
  Fix error in the code snippet for Symbol (mdn#33765)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants