Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Module page: CSS Shapes #33809

Merged
merged 23 commits into from
May 30, 2024
Merged

CSS Module page: CSS Shapes #33809

merged 23 commits into from
May 30, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented May 29, 2024

update the css module landing page for CSS shapes. Fixes openwebdocs/project#204

note: previous pr was closed b/c the plethora of bot comments made it look like this was being reviewed. There's still a bot comment, but i don't knwo what the issue there is.

@estelle estelle requested a review from a team as a code owner May 29, 2024 02:30
@estelle estelle requested review from dipikabh and removed request for a team May 29, 2024 02:30
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels May 29, 2024
Copy link
Contributor

github-actions bot commented May 29, 2024

Preview URLs

External URLs (7)

URL: /en-US/docs/Web/CSS/CSS_shapes
Title: CSS shapes


URL: /en-US/docs/Web/CSS/CSS_shapes/Basic_shapes
Title: Basic shapes

(comment last updated: 2024-05-30 06:30:33)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle few comments for you; looking mostly good.

files/en-us/web/css/css_shapes/basic_shapes/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_shapes/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_shapes/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_shapes/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_shapes/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_shapes/index.md Outdated Show resolved Hide resolved
estelle and others added 2 commits May 29, 2024 11:48
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle
Copy link
Member Author

estelle commented May 29, 2024

i think i was able to fix the flaw too. Still not sure what caused it, but i added an empty line at the end of the page, and that made it happy.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle super awesome groovy yeahhhhh.

@chrisdavidmills chrisdavidmills merged commit 9660f20 into mdn:main May 30, 2024
8 checks passed
@estelle estelle deleted the shapes branch May 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Module: CSS Shapes
2 participants