Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set handle value #33827

Merged
merged 1 commit into from
May 30, 2024
Merged

set handle value #33827

merged 1 commit into from
May 30, 2024

Conversation

hotsphink
Copy link
Contributor

handle is passed to self.cancelAnimationFrame, but it was never declared nor set to anything.

Description

set handle to cancellation token

Motivation

existing code is buggy

Additional details

Related issues and pull requests

`handle` is passed to `self.cancelAnimationFrame`, but it was never declared nor set to anything.
@hotsphink hotsphink requested a review from a team as a code owner May 30, 2024 00:37
@hotsphink hotsphink requested review from Elchi3 and removed request for a team May 30, 2024 00:37
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 30, 2024
Copy link
Contributor

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit 26f776d into mdn:main May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants