Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS module: logical props #33901

Merged
merged 18 commits into from
Jun 5, 2024
Merged

CSS module: logical props #33901

merged 18 commits into from
Jun 5, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 3, 2024 •
edited
Loading

replaces #33849, which has become borked locally.

fixes openwebdocs/project#205

@estelle estelle requested review from a team as code owners June 3, 2024 20:47
@estelle estelle requested review from chrisdavidmills and removed request for a team June 3, 2024 20:47
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Jun 3, 2024
@estelle estelle mentioned this pull request Jun 3, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Preview URLs

Flaws (7)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Glossary/Flow_relative_values
Title: Flow relative values
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/physical_properties does not exist
    • /en-US/docs/Glossary/logical_properties does not exist

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values
Title: CSS logical properties and values
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/Logical_properties does not exist
    • /en-US/docs/Glossary/Physical_properties does not exist

URL: /en-US/docs/Web/CSS/CSS_Values_and_Units
Title: CSS values and units
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/toggle does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Glossary/flow_relative_values
    • Can't resolve /en-US/docs/Glossary/flow_relative_values
External URLs (3)

URL: /en-US/docs/Learn/CSS/Building_blocks/Backgrounds_and_borders
Title: Backgrounds and borders

(comment last updated: 2024-06-04 17:47:42)

@estelle estelle mentioned this pull request Jun 4, 2024
Closed
13 tasks
chrisdavidmills
chrisdavidmills requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle thanks! I've just got a few comments for you to consider.

files/en-us/glossary/flow_relative_values/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/flow_relative_values/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/flow_relative_values/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/flow_relative_values/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/flow_relative_values/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_logical_properties_and_values/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_logical_properties_and_values/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_logical_properties_and_values/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_logical_properties_and_values/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_logical_properties_and_values/index.md Outdated Show resolved Hide resolved
estelle and others added 6 commits June 4, 2024 10:22
@estelle @chrisdavidmills
Apply suggestions from code review
bbdc224 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @chrisdavidmills
Apply suggestions from code review
465025f 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @chrisdavidmills
Apply suggestions from code review
c03fad0 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @chrisdavidmills
Apply suggestions from code review
9fbd6ac 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @chrisdavidmills
Update files/en-us/web/css/css_logical_properties_and_values/index.md
e815d45 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @chrisdavidmills
Apply suggestions from code review
747f5f8 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @github-actions
Update files/en-us/web/css/css_logical_properties_and_values/index.md
364a1b1 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle and others added 4 commits June 4, 2024 10:25
chrisdavidmills
chrisdavidmills approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's get this merged! Awesome work @estelle.

@chrisdavidmills chrisdavidmills merged commit 63249f6 into main Jun 5, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the logic3 branch June 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Logical Properties and Values
2 participants
@estelle @chrisdavidmills