Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: CSS flex guide: updates to guide 5 #34237

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Maintenance: CSS flex guide: updates to guide 5 #34237

merged 10 commits into from
Jul 3, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 18, 2024

Flexbox is well-supported, and the content value is fully supported. This update freshens up the guide and removes a lot of words to tighten it up, then adds clarification text, so it's about the same size :(.

updating guide as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 18, 2024 02:55
@estelle estelle requested review from dipikabh and removed request for a team June 18, 2024 02:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

Preview URLs

(comment last updated: 2024-07-03 16:05:13)

@estelle estelle changed the title Maintenance: CSS flex guide: updates to guide 3 Maintenance: CSS flex guide: updates to guide 5 Jun 18, 2024
@estelle estelle mentioned this pull request Jun 18, 2024
29 tasks
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 28, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 28, 2024
…_of_flex_items_along_the_main_axis/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this content, @estelle. I've added my editorial review.

estelle and others added 2 commits June 28, 2024 19:03
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
estelle and others added 3 commits July 2, 2024 11:49
…_of_flex_items_along_the_main_axis/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from dipikabh July 3, 2024 01:30
@estelle
Copy link
Member Author

estelle commented Jul 3, 2024

Thanks for the review. I've incorporated all your feedback. I also updated all the live examples because the flex container overflowed the example space on smaller screens. mdn/css-examples#187

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the updates look good. There's only a very few nits. I can commit those and merge this PR.

@dipikabh dipikabh merged commit e3468fc into main Jul 3, 2024
9 checks passed
@dipikabh dipikabh deleted the flex-guide5 branch July 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants