Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS maintenance: flex-grow property #34240

Merged
merged 5 commits into from
Jun 24, 2024
Merged

CSS maintenance: flex-grow property #34240

merged 5 commits into from
Jun 24, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 18, 2024

  • added maths and example of flex grow distribution
  • removed default values from example
  • removed wrapping, as wrapping creates a new line, which could bork the example.
  • updated see also
  • nits, because why not.

@estelle estelle requested a review from a team as a code owner June 18, 2024 04:17
@estelle estelle requested review from chrisdavidmills and removed request for a team June 18, 2024 04:17
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jun 18, 2024
github-actions[bot]
github-actions bot reviewed Jun 18, 2024
View reviewed changes
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
@estelle estelle mentioned this pull request Jun 18, 2024
Closed
29 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/flex-grow
Title: flex-grow

(comment last updated: 2024-06-24 18:09:04)

estelle and others added 2 commits June 17, 2024 21:19
@estelle @github-actions
Update files/en-us/web/css/flex-grow/index.md
39c30a8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle @github-actions
Update files/en-us/web/css/flex-grow/index.md
dd1c723 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrisdavidmills
chrisdavidmills approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle few suggestions for you. Approving so as not to hold you up.

files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-grow/index.md Outdated Show resolved Hide resolved
@estelle @chrisdavidmills
Apply suggestions from code review
977e778 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle @github-actions
Update files/en-us/web/css/flex-grow/index.md
2c2c51c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle merged commit 76eacc8 into main Jun 24, 2024
9 checks passed
@estelle estelle deleted the estelle-patch-4-1 branch June 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills