Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: justify-content maintenance updates #34502

Merged
merged 18 commits into from
Jul 18, 2024
Merged

CSS: justify-content maintenance updates #34502

merged 18 commits into from
Jul 18, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 29, 2024

Updated the justify-content property.

Moved descriptive text into a description section.
added flex and grid-related content.
Added information about multi-line 

Converted the example to a multi-line example to demonstrate the effect are per flex line.,
Also added a grid example demonstrating effect is on grid columns only, with no effect on grid items themselves.

P.S. was sick when i updated this content (and still am), so if it isn't well explained, please let me know so i can fix .

@estelle estelle requested a review from a team as a code owner June 29, 2024 07:27
@estelle estelle requested review from chrisdavidmills and removed request for a team June 29, 2024 07:27
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jun 29, 2024
@estelle estelle mentioned this pull request Jun 29, 2024
29 tasks
Copy link
Contributor

github-actions bot commented Jun 29, 2024

Preview URLs

(comment last updated: 2024-07-18 04:16:33)

files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved

{{EmbedLiveSample("Basic grid example", "100%", 220)}}

Note that `justify-contents` aligns the columns and has no effect on the items or alignment in grid areas. Grid items, even those that overflow their grid cell, do not impact column justification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can show a screenshot to give a better picture:
1
(The screenshot was taken using Chrome dev tools.)

files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Show resolved Hide resolved
@chrisdavidmills chrisdavidmills removed their request for review July 1, 2024 15:42
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
estelle and others added 4 commits July 1, 2024 10:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from OnkarRuikar July 2, 2024 05:49
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. And need to change the safe example.


### The safe keyword

This example demonstrates the `safe` keyterm. The HTML and CSS is the same as in the above example, except for the `justify-content` values:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use the same example for safe and unsafe. Safe and unsafe require item overflow.
We could use this demo: https://jsfiddle.net/51af3k9m/2/

}

.container:last-of-type {
justify-content: safe space-around;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wrong value. From the syntax <overflow-position>? [ <content-position> | left | right ] only safe (center|start|end|flex-start|flex-end|left|right) values are valid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redid the example completely

files/en-us/web/css/justify-content/index.md Show resolved Hide resolved
@estelle estelle requested a review from OnkarRuikar July 9, 2024 21:51
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
@estelle estelle requested a review from OnkarRuikar July 10, 2024 06:32
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's complete the example.

files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
@estelle estelle requested review from OnkarRuikar and chrisdavidmills and removed request for OnkarRuikar July 10, 2024 14:42
@OnkarRuikar
Copy link
Contributor

Looks good to me.

@Josh-Cena Josh-Cena changed the title CSS: justify-content CSS: justify-content maintenance updates Jul 12, 2024
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @estelle; just a few small suggestions for you to consider.

files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/justify-content/index.md Outdated Show resolved Hide resolved
estelle and others added 2 commits July 17, 2024 21:14
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle merged commit 435c9c5 into main Jul 18, 2024
9 checks passed
@estelle estelle deleted the justifycontent branch July 18, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants