Fix documentation of FocusOptions.focusVisible. #34875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`focusVisible: false` is not equivalent to not specifying the option as the current text implies. The spec is clear, and only indicates focus if focusVisible is true, or not specified and a browser-heuristic matches, see [1]: > If the value of the `focusVisible` dictionary member of options is > `true`, or is not present but in an implementation-defined way the > user agent determines it would be best to do so, then indicate focus. That condition doesn't match if the member is present and is `false` :) [1]: https://html.spec.whatwg.org/#dom-focus
github-actions
bot
added
Content:WebAPI
|
Preview URLs |
sideshowbarker
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focusVisible: falseis not equivalent to not specifying the option as the current text implies.The spec is clear, and only indicates focus if focusVisible is true, or not specified and a browser-heuristic matches, see 1:
That condition doesn't match if the member is present and is
false:)Motivation
It's wrong. There seems to be confusion in issues like w3c/csswg-drafts#5885, partially due to the wrong MDN documentation.
Additional details
I wrote the spec (see whatwg/html#8087), and this was explicitly discussed in the WHATWG in the various meetings referenced from whatwg/html#7830 :)