Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid links #34975

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix invalid links #34975

merged 1 commit into from
Jul 22, 2024

Conversation

Josh-Cena
Copy link
Member

I'm working on another MDN link checker tool. This tool has caught a lot of bad links.

@Josh-Cena Josh-Cena requested review from a team as code owners July 22, 2024 20:47
@Josh-Cena Josh-Cena requested review from bsmth, wbamberg and estelle and removed request for a team July 22, 2024 20:47
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs Content:PWA Progressive Web Apps content size/s [PR only] 6-50 LoC changed labels Jul 22, 2024
Copy link
Contributor

github-actions bot commented Jul 22, 2024

Preview URLs (15 pages)
Flaws (55)

Note! 12 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 for developers
Flaw count: 51

  • macros:
    • /en-US/docs/Web/HTML/Element/isindex does not exist
    • /en-US/docs/Web/API/Element/isContentEditable does not exist
    • /en-US/docs/Web/API/Element/onbeforescriptexecute does not exist
    • /en-US/docs/Web/API/Element/onafterscriptexecute does not exist
    • /en-US/docs/Web/API/Event/mozInputSource does not exist
    • and 7 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Optimizing_graphics_performance
    • Can't resolve /en-US/docs/DOM/Animations_using_MozBeforePaint
    • Can't resolve /en-US/docs/DOM/HTMLWBRElement
    • Can't resolve /en-US/docs/Supporting_private_browsing_mode#detecting_whether_private_browsing_mode_is_permanent
    • Can't resolve /en-US/docs/DOM/event/StorageEvent
    • and 34 more flaws omitted

URL: /en-US/docs/Web/HTML/Attributes/max
Title: HTML attribute: max
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/low
    • Can't resolve /en-US/docs/Web/HTML/Attributes/high
    • Can't resolve /en-US/docs/Web/HTML/Attributes/optimum

URL: /en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key
Title: The page-type front matter key
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/WebAssembly/JavaScript_interface/instantiate
External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Releases/92
Title: Firefox 92 for developers


URL: /en-US/docs/Web/HTML/Global_attributes/itemscope
Title: itemscope


URL: /en-US/docs/Web/Security/Practical_implementation_guides/CORP
Title: Cross-Origin Resource Policy (CORP) implementation

(comment last updated: 2024-07-22 21:35:15)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit 611b452 into mdn:main Jul 22, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-links branch July 22, 2024 22:24
@bsmth
Copy link
Member

bsmth commented Jul 23, 2024

Nice, thank you, Josh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Meta Content in the meta docs Content:PWA Progressive Web Apps content Content:Security Security docs Content:SVG SVG docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants