fix(ci): don't report a broken fragment if duplicate fragment exists #35577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
system
|
@pepelsbey Can you please look at this sooner rather than later? I think it would be good for this to go in before I merge #35441, but I also would like that in for the release this week. |
Josh-Cena
reviewed
Aug 26, 2024
Vadim is on PTO this week so I've added myself as a reviewer |
github-actions
bot
added
size/m
Josh-Cena
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Tested and it works. Letting @bsmth take another look. Otherwise I'll merge it tonight, just so @hamishwillee can work on his stuff when he wakes up.
bsmth
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file has two headers with the same text and one header is updated, then the script reports it as a broken fragment. The PR adds logic to check if the file has headers with the same content.