Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made an addTextTrack() page #36100

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

made an addTextTrack() page #36100

wants to merge 3 commits into from
+69 −0

Conversation

gusborg88
Copy link

Description

I made a new page for HTMLMediaElement.addTextTrack(), I could't find what exceptions it throws though so that might need to be fixed.

Motivation

I'm working with this method right now, and I noticed MDN didn't have a page, so I made one.

Additional details

I found most of the info here: https://html.spec.whatwg.org/multipage/media.html#dom-media-addtexttrack

Related issues and pull requests

@gusborg88 gusborg88 requested a review from a team as a code owner September 29, 2024 02:06
@gusborg88 gusborg88 requested review from Elchi3 and removed request for a team September 29, 2024 02:06
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Sep 29, 2024
@gusborg88
Forgot a right brace
56a3c12 
whoopsie daisies
Josh-Cena
Josh-Cena requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gusborg88! Thanks for your contribution. I have a few suggestions to make it follow MDN's latest guidelines and conventions.

files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/addtexttrack/index.md Show resolved Hide resolved
gusborg88
gusborg88 commented Sep 29, 2024
View reviewed changes
Copy link
Author

@gusborg88 gusborg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits, looks pretty good! I agree that the usage notes should be moved to the intro, im gonna do that in a minute

@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/API/HTMLMediaElement/addTextTrack
Title: HTMLMediaElement: addTextTrack() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Addtrack does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena requested changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusborg88 @Josh-Cena