Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about non-depth bias for line and point topologies #36482

Merged

Conversation

chrisdavidmills
Copy link
Contributor

Description

Chrome 128 deprecates setting depth bias for lines and points (Chrome issue, spec change).

This PR updates the GPUDevice.createRenderPipeline() page to:

  • include a note in the depthStencil object description saying that the depthBias, depthBiasClamp, and depthBiasSlopeScale properties must be set to 0 for line and point topologies.
  • echo this same information with a new entry in the Validation section.

Motivation

Additional details

See the description and data source

Related issues and pull requests

See related MDN project issue: #36341

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner October 24, 2024 08:54
@chrisdavidmills chrisdavidmills requested review from sideshowbarker and removed request for a team October 24, 2024 08:54
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Oct 24, 2024
Copy link
Contributor

@sideshowbarker sideshowbarker merged commit da15f25 into mdn:main Oct 24, 2024
7 checks passed
Copy link
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this applies to createRenderPipelineAsync() as well

@chrisdavidmills
Copy link
Contributor Author

Note that this applies to createRenderPipelineAsync() as well

That's fine. The descriptor structure is documented only on createRenderPipeline(), and we then link to it from createRenderPipelineAsync().

@beaufortfrancois
Copy link
Contributor

https://developer.mozilla.org/en-US/docs/Web/API/GPUDevice/createRenderPipelineAsync validation suggests there is more though no?

@chrisdavidmills
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/API/GPUDevice/createRenderPipelineAsync validation suggests there is more though no?

I'm not 100% sure what you mean, but I did notice that the validation line was missing from the async page. I've added it in #36489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants