Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF133 Renote: beforetoggle, toggle fire on dialogs #36654

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Nov 5, 2024

FF133 adds support for the toggle and beforetoggle events being fired at dialogs. THis adds a release note.

Related docs work tracked in #36536

@hamishwillee hamishwillee requested a review from a team as a code owner November 5, 2024 02:39
@hamishwillee hamishwillee requested review from pepelsbey and removed request for a team November 5, 2024 02:39
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/133
Title: Firefox 133 for developers

(comment last updated: 2024-11-14 23:28:28)

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one suggestion :)

files/en-us/mozilla/firefox/releases/133/index.md Outdated Show resolved Hide resolved
@hamishwillee hamishwillee merged commit 46708b2 into mdn:main Nov 14, 2024
8 checks passed
@hamishwillee hamishwillee deleted the ff133relnote_beforetoggle branch November 14, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants