Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMRect instance properties #36704

Merged
merged 13 commits into from
Nov 17, 2024
Merged

DOMRect instance properties #36704

merged 13 commits into from
Nov 17, 2024

Conversation

yashrajbharti
Copy link
Contributor

Description

Added DOMRect: x, y, height, width instance properties to MDN Feature pages. This is a part of Missing Widely Available MDN feature pages

Motivation

My motivation is a mix of my talk with @estelle , my love for open source and desire to make the docs up to date with the forever growing HTML web apis.

Additional details

https://drafts.fxtf.org/geometry/#DOMRect
https://openwebdocs.github.io/web-docs-backlog/baseline/

Related issues and pull requests

@yashrajbharti yashrajbharti requested a review from a team as a code owner November 9, 2024 17:45
@yashrajbharti yashrajbharti requested review from wbamberg and removed request for a team November 9, 2024 17:45
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions....

files/en-us/web/api/domrect/domrect/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/domrect/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/domrect/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/domrect/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/height/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/width/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/x/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/y/index.md Outdated Show resolved Hide resolved
yashrajbharti and others added 8 commits November 16, 2024 18:24
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
files/en-us/web/api/domrect/x/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/x/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/y/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domrect/y/index.md Outdated Show resolved Hide resolved
yashrajbharti and others added 4 commits November 16, 2024 18:27
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit dc82e60 into mdn:main Nov 17, 2024
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/DOMRect branch November 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants