Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Move CSS examples - Modules, filter functions, flow layout, grid layout #36752

Merged
merged 18 commits into from
Nov 14, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 12, 2024

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/modules/animation.html", '100%', 650)}}
{{EmbedGHLiveSample("css-examples/modules/backgrounds.html", '100%', 430)}}
{{EmbedGHLiveSample("css-examples/modules/basicUI.html", '100%', 320)}}
{{EmbedGHLiveSample("css-examples/box-alignment/overview/grid-align-items.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/box-alignment/overview/flex-align-items.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/box-alignment/overview/grid-gap.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/modules/compositing.html", '100%', 460)}}
{{EmbedGHLiveSample("css-examples/layout/normal-flow.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/flow/formatting-contexts/float.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/flow/formatting-contexts/bfc-overflow.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/flow/formatting-contexts/bfc-flow-root.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/flow/formatting-contexts/inline.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/modules/generated_content.html", '100%',420)}}
{{EmbedGHLiveSample("css-examples/grid/docs/autoplacement.html", '100%', 1200)}}
{{EmbedGHLiveSample("css-examples/types/filterfunctions.html", '100%', '500')}}
{{EmbedGHLiveSample("css-examples/inline-formatting/inline.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/inline-formatting/break.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/inline-formatting/mbp.html", '100%', 920)}}
{{EmbedGHLiveSample("css-examples/inline-formatting/align.html", '100%', 920)}}
{{EmbedGHLiveSample("css-examples/inline-formatting/text-align.html", '100%', 920)}}
{{EmbedGHLiveSample("css-examples/flow/formatting-contexts/float.html", '100%', 720)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner November 12, 2024 12:09
@bsmth bsmth requested review from chrisdavidmills and removed request for a team November 12, 2024 12:09
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xl [PR only] >1000 LoC changed labels Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Preview URLs (12 pages)
Flaws (8)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_basic_user_interface
Title: CSS basic user interface
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/caret does not exist
    • /en-US/docs/Web/CSS/caret-shape does not exist
    • /en-US/docs/Web/CSS/nav-down does not exist
    • /en-US/docs/Web/CSS/nav-left does not exist
    • /en-US/docs/Web/CSS/nav-right does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/CSS_backgrounds_and_borders
Title: CSS backgrounds and borders
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/background-position-inline does not exist
    • /en-US/docs/Web/CSS/background-position-block does not exist

(comment last updated: 2024-11-14 10:41:17)

bsmth and others added 2 commits November 13, 2024 12:53
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bsmth bsmth requested a review from Rumyra November 13, 2024 11:55
@bsmth
Copy link
Member Author

bsmth commented Nov 14, 2024

Thank you!

@bsmth bsmth merged commit 5755d6d into mdn:main Nov 14, 2024
8 checks passed
@bsmth bsmth deleted the css-examples-web-css-4 branch November 14, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants