Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rari): support for template l10n and new sidebars #36755

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Nov 12, 2024

Description

This prepares for the new sidebars and L10n for macros (templates) is moved to jsondata.

Note

MDN engineering will back port any changes to sidebars or macros from yari until we make a cut over.

Motivation

Prepare to merge mdn/yari#12051

Additional details

For now these are protected by the code owners but will be opened up soon.

For now these are protected by the code owners but will
be opened up soon.

Co-authored-by: Andi Pieper <apieper@mozilla.com>
@fiji-flo fiji-flo requested review from a team as code owners November 12, 2024 14:35
@fiji-flo fiji-flo requested review from pepelsbey and removed request for a team November 12, 2024 14:35
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/xl [PR only] >1000 LoC changed labels Nov 12, 2024
title: Forums
- link: https://stackoverflow.com/questions/tagged/firefox-addon
title: Stack_Overflow
- link: /Mozilla/Add-ons#contact_us
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether it is possible to localize the URL fragment here. As for zh-CN the link should be Mozilla/Add-ons#联系我们 instead of Mozilla/Add-ons#contact_us

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, that's broken right now, but I can add a hash attribute that has to be localized. I'll draft this up. But would block this on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support added see: 6a8f776

We might want to see how it goes, but that's the best way for now. I did realized this sidebar even though localized is only used in en-US,ru and ja.

@OnkarRuikar
Copy link
Contributor

Is there a way to auto-update sidebar files when a page is moved?
Or, at least, some checks are needed in pre-commit and GitHub PR checks to prevent merges without updating the sidebar config files.

@fiji-flo
Copy link
Contributor Author

That will become part of content move yes. For now it's like yari and all these are smart links as in they will follow redirect. But when we fully switch this will be updated by tooling.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, leaving a +1 from me 🏎️

@fiji-flo fiji-flo merged commit 1469cc4 into main Nov 14, 2024
8 of 9 checks passed
@fiji-flo fiji-flo deleted the rari-content branch November 14, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xl [PR only] >1000 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants