-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rari): support for template l10n and new sidebars #36755
Conversation
For now these are protected by the code owners but will be opened up soon. Co-authored-by: Andi Pieper <apieper@mozilla.com>
files/sidebars/addonsidebarmain.yaml
Outdated
title: Forums | ||
- link: https://stackoverflow.com/questions/tagged/firefox-addon | ||
title: Stack_Overflow | ||
- link: /Mozilla/Add-ons#contact_us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether it is possible to localize the URL fragment here. As for zh-CN
the link should be Mozilla/Add-ons#联系我们
instead of Mozilla/Add-ons#contact_us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, that's broken right now, but I can add a hash
attribute that has to be localized. I'll draft this up. But would block this on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support added see: 6a8f776
We might want to see how it goes, but that's the best way for now. I did realized this sidebar even though localized is only used in en-US
,ru
and ja
.
Is there a way to auto-update sidebar files when a page is moved? |
That will become part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, leaving a +1 from me 🏎️
Description
This prepares for the new sidebars and L10n for macros (templates) is moved to jsondata.
Note
MDN engineering will back port any changes to sidebars or macros from yari until we make a cut over.
Motivation
Prepare to merge mdn/yari#12051
Additional details
For now these are protected by the code owners but will be opened up soon.