-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demix ChildNode.remove to Element, CharacterData, DocumentType #5088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but nothing much. Nice work @Elchi3 !
--- | ||
<div>{{APIRef("DOM")}}</div> | ||
|
||
<p>The <code><strong>DocumentType.remove()</strong></code> method removes a document's <code>doctype</code>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you ever want to do this? I do wonder if it's possible to add a line or two describing why you might want to do this, if such information is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why anyone wants to do it, but if it is because of getting to quirks mode, I've added a note to the doc saying that this is a bad idea.
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-05-19 14:05:46.620797) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looking good to go. Nice one @Elchi3 !
The abstract mixin page
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove
becomes
https://developer.mozilla.org/en-US/docs/Web/API/Element/remove
https://developer.mozilla.org/en-US/docs/Web/API/CharacterData/remove
https://developer.mozilla.org/en-US/docs/Web/API/DocumentType/remove
IDL
https://dom.spec.whatwg.org/#interface-childnode
BCD
mdn/browser-compat-data#10506