-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client hint docs: Downlink, ECT, RTT #5883
Conversation
@Elchi3 OK, this got bigger
I think this is a good place to stop for now. In future though it might be worth having a client headers guide much like https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/client-hints and cut back the glossary entry. This gives us a structure to work with now though. Can you please review again :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Some comments.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@Elchi3 Thanks for the detailed review - I seem to have injected more errors than usual :-(. I accepted all changes, added directives sections, reverted the specifications section. Note that I kept the specifications macro for the new header docs. Yes they show missing info now, but I'm hoping that the spec issue will be resolved soon and don't think it worth adding the manual table while we wait. Happy to add a manual table if you think this is a "requirement". |
This was the correct call! These headers use https://wicg.github.io/netinfo/ which does in fact work as soon as the latest BCD is on MDN production in a few hours. What doesn't work right now is HTTP features that reference IETF specs. You can follow w3c/browser-specs#280 to be notified when it's available upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hamish, fantastic work! 👍
This header is in the Network Information spec here: https://wicg.github.io/netinfo/#rtt-request-header-field
There is not all that much information, but you can see it is associated with the NetworkInformation.rtt and there is some useful general guidance in https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/client-hints.
Spec update is in mdn/browser-compat-data#10951
This is another part of #1408