Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebRTC identity events and update some examples #6109

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jun 18, 2021

@foolip foolip requested review from a team as code owners June 18, 2021 13:11
@foolip foolip requested review from Rumyra and removed request for a team June 18, 2021 13:11
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/WebRTC_API
Title: WebRTC API
on GitHub
Flaw count: 11

  • macros:
    • /en-US/docs/Web/API/RTCDtlsTransport/statechange_event does not exist
    • /en-US/docs/Web/API/RTCSctpTransport/statechange_event does not exist
    • /en-US/docs/Web/API/RTCIdentityProvider does not exist
    • /en-US/docs/Web/API/RTCIdentityProviderRegistrar does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/Event
Title: Event
on GitHub
Flaw count: 15

  • macros:
    • /en-US/docs/Web/API/BeforeInputEvent does not exist
    • /en-US/docs/Web/API/CSSFontFaceLoadEvent does not exist
    • /en-US/docs/Web/API/DOMTransactionEvent does not exist
    • /en-US/docs/Web/API/EditingBeforeInputEvent does not exist
    • /en-US/docs/Web/API/RelatedEvent does not exist
    • and 7 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/RTCPeerConnection
Title: RTCPeerConnection
on GitHub
Flaw count: 15

  • macros:
    • /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
  • broken_links:
    • Is currently http:// but can become https://
  • sectioning:
    • Excess <h2> tag that is NOT at root-level (id='Properties', text='Properties')
    • Excess <h2> tag that is NOT at root-level (id='Methods', text='Methods')
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/RTCPeerConnection/setIdentityProvider
Title: RTCPeerConnection.setIdentityProvider()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/API/RTCPeerConnection/getIdentityAssertion
Title: RTCPeerConnection.getIdentityAssertion()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/API/WebRTC
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/unload_event

External URLs

URL: /en-US/docs/Web/API/WebRTC_API
Title: WebRTC API
on GitHub


URL: /en-US/docs/Web/API/Event
Title: Event
on GitHub

No external URLs


URL: /en-US/docs/Web/API/RTCPeerConnection
Title: RTCPeerConnection
on GitHub


URL: /en-US/docs/Web/API/RTCPeerConnection/setIdentityProvider
Title: RTCPeerConnection.setIdentityProvider()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCPeerConnection/getIdentityAssertion
Title: RTCPeerConnection.getIdentityAssertion()
on GitHub

No new external URLs


URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub

@sideshowbarker sideshowbarker merged commit e93201a into mdn:main Jun 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants