Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation for the RequestDestination enum #6466

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Remove documentation for the RequestDestination enum #6466

merged 1 commit into from
Jun 30, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the RequestDestination enum from our documentation, folding its data into Request.destination. This is to go along with mdn/browser-compat-data#11323.

@queengooborg queengooborg requested review from a team as code owners June 30, 2021 05:40
@queengooborg queengooborg requested review from Rumyra and removed request for a team June 30, 2021 05:40
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Request
Title: Request
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/body (url: /en-US/docs/Web/API/Body) does not exist
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Request/destination
Title: Request.destination
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/body (url: /en-US/docs/Web/API/Body) does not exist
    • /en-US/docs/Web/API/RequestDestination redirects to /en-US/docs/Web/API/Request/destination

External URLs

URL: /en-US/docs/Web/API/Request
Title: Request
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Request/destination
Title: Request.destination
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Sec-Fetch-Dest
Title: Sec-Fetch-Dest
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see these simplifications 👍

@wbamberg wbamberg merged commit f8f462d into mdn:main Jun 30, 2021
@queengooborg queengooborg deleted the remove-RequestDestination branch June 30, 2021 20:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants