Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix PaymentDetailsBase and remove it #6640

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Jul 7, 2021

PaymentDetailsBase is a mixin of… dictionaries.

One of the two dictionaries is not documented at all (I removed any mention of it in this PR), and the other already had the info incorporated (I removed the red links to subpages of PaymentDetailsBase, so it doesn't reappear in the future).

Then I just deleted PaymentDetailsBase.

Companion PR:

@teoli2003 teoli2003 requested review from a team as code owners July 7, 2021 11:01
@teoli2003 teoli2003 requested review from rachelandrew and sideshowbarker and removed request for a team July 7, 2021 11:01
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PaymentDetailsUpdate
Title: PaymentDetailsUpdate
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/PaymentDetailsUpdate/updateWith does not exist
    • /en-US/docs/Web/API/PaymentDetailsModifier does not exist
    • /en-US/docs/Web/API/PaymentShippingOption does not exist
    • /en-US/docs/Web/API/PaymentDetailsUpdate/total does not exist
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/PaymentDetailsUpdate
Title: PaymentDetailsUpdate
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PaymentRequest/id
Title: PaymentRequest.prototype.id
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 06f9c36 into mdn:main Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants