-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagemacro: include rather than transclude EffectTiming properties #7644
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-09-01 03:01:46.543388) |
Not merging, because I don’t have answers to the questions in the issue description… |
Thanks! |
To answer the 2nd question, I think |
By now, a wild merge conflict appeared. |
I resolved the merge conflicts. |
Thanks. I should have merged as is, but was still hoping for response from Florian. Better in than out. I'll think some more on this. |
Sorry, I missed this in all the notifications. It looks good to me. I think whether or not to consolidate EffectTiming under some constructors and not as a dictionary on its own is mostly best answered in BCD. Meaning that if we think we can make sensible structures there, the separate dictionary pages might not be needed. But this can be a follow-up. Thanks for getting rid of the page macro already. mdn/browser-compat-data#7287 and mdn/browser-compat-data#6810 are related. |
This is part of fixing #3196 - replaces a page inclusion macro of the EffectTiming dictionary properties into the two places it is used: Element.animate(), KeyframeEffect()
I would like to update further, perhaps as a post process. To help with that, answers to the following would be great.
KeyframeEffectReadOnly()
that redirects to KeyframeEffect() and aAnimationEffectReadOnly
which we don't document. I can't see in spec but they do appear in https://docs1.w3cub.com/haxe~javascript/html/animationeffectreadonly/ . Is it "valid" or are these things that no longer really exist?Element.animate()
compatibility. I presume the action here is to update that with each of these options?